Implement configureFieldIndexes with tests#6403
Merged
tom-andersen merged 17 commits intomasterfrom Jul 26, 2022
Merged
Conversation
🦋 Changeset detectedLatest commit: 82f0e60 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Collaborator
Size Report 1Affected Products
Test Logs |
Collaborator
Size Analysis Report 1This report is too large (640,509 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.Test Logs |
tom-andersen
commented
Jun 30, 2022
| @@ -473,24 +473,25 @@ export class FirebaseAppCheckTokenProvider | |||
| asyncQueue: AsyncQueue, | |||
| changeListener: CredentialChangeListener<string> | |||
Contributor
Author
There was a problem hiding this comment.
This file is just whitespace formatting that happens when the lint:fix and yarn prettier are run.
tom-andersen
commented
Jun 30, 2022
wu-hui
reviewed
Jul 6, 2022
Contributor
wu-hui
left a comment
wu-hui
left a comment
There was a problem hiding this comment.
Mostly ready to merge. I have a kind of big ask to add a spec test..
| } | ||
| const tokenUpdated = tokenResult.token !== this.latestAppCheckToken; | ||
| this.latestAppCheckToken = tokenResult.token; | ||
| const onTokenChanged: ( |
Contributor
Author
There was a problem hiding this comment.
The is the linter making things pretty.
It's a minor nuisance to omit committing this file every time I work on JS. So I let it slide this time, and thought it could be included.
This is purely a whitespace change.
Contributor
There was a problem hiding this comment.
This does not look like a whitespace change to me..the error message changed for example.
Contributor
Author
There was a problem hiding this comment.
Take a closer look. Githubs diff layout is misleading you.
Contributor
Changeset File Check ✅
|
wu-hui
reviewed
Jul 21, 2022
Contributor
wu-hui
left a comment
wu-hui
left a comment
There was a problem hiding this comment.
Almost LGTM, I believe the app check change worth taking another look.
| } | ||
| const tokenUpdated = tokenResult.token !== this.latestAppCheckToken; | ||
| this.latestAppCheckToken = tokenResult.token; | ||
| const onTokenChanged: ( |
Contributor
There was a problem hiding this comment.
This does not look like a whitespace change to me..the error message changed for example.
wu-hui
approved these changes
Jul 22, 2022
| } | ||
| const tokenUpdated = tokenResult.token !== this.latestAppCheckToken; | ||
| this.latestAppCheckToken = tokenResult.token; | ||
| const onTokenChanged: ( |
hsubox76
reviewed
Jul 25, 2022
hsubox76
approved these changes
Jul 26, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.