Skip to content

Commit 4e99d4b

Browse files
authored
fix(firestore): read user data in internal pipeline proto serialization (#9752)
1 parent 5a5db88 commit 4e99d4b

2 files changed

Lines changed: 18 additions & 0 deletions

File tree

.changeset/sour-peaches-attend.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@firebase/firestore': patch
3+
---
4+
5+
Read user data when using internal pipeline proto serialization.

packages/firestore/src/remote/internal_serializer.ts

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,10 @@ import { AggregateSpec } from '../lite-api/aggregate_types';
2626
import { getDatastore } from '../lite-api/components';
2727
import { Pipeline } from '../lite-api/pipeline';
2828
import { Query } from '../lite-api/reference';
29+
import {
30+
newUserDataReader,
31+
UserDataSource
32+
} from '../lite-api/user_data_reader';
2933
import { ExecutePipelineRequest as ProtoExecutePipelineRequest } from '../protos/firestore_proto_api';
3034
import { cast } from '../util/input_validation';
3135
import { mapToArray } from '../util/obj';
@@ -116,6 +120,15 @@ export function _internalPipelineToExecutePipelineRequestProto(
116120
// eslint-disable-next-line @typescript-eslint/no-explicit-any
117121
): any {
118122
const firestore = cast(pipeline._db, Firestore);
123+
124+
const userDataReader = newUserDataReader(firestore);
125+
const context = userDataReader.createContext(
126+
UserDataSource.Argument,
127+
'_internalPipelineToExecutePipelineRequestProto'
128+
);
129+
130+
pipeline._readUserData(context);
131+
119132
const datastore = getDatastore(firestore);
120133
const serializer = datastore.serializer;
121134
if (serializer === undefined) {

0 commit comments

Comments
 (0)