resolve comments

milaGGL · milaGGL · commit 2c667fa3b68d · 2022-09-01T10:25:17.000-07:00
diff --git a/packages/firestore/src/protos/google/firestore/v1/query.proto b/packages/firestore/src/protos/google/firestore/v1/query.proto
@@ -309,7 +309,7 @@ message StructuredAggregationQuery {
       // Requires:
       //
       // * Must be greater than zero when present.
-      int64 up_to = 1;
+      google.protobuf.Int64Value up_to = 1;
     }
 
     // The type of aggregation to perform, required.
diff --git a/packages/firestore/src/protos/protos.json b/packages/firestore/src/protos/protos.json
@@ -2427,7 +2427,7 @@
                         "Count": {
                           "fields": {
                             "upTo": {
-                              "type": "int32",
+                              "type": "google.protobuf.Int64Value",
                               "id": 1
                             }
                           }

Original file line number	Diff line number	Diff line change
`@@ -309,7 +309,7 @@ message StructuredAggregationQuery {`
`309`	`309`	`// Requires:`
`310`	`310`	`//`
`311`	`311`	`// * Must be greater than zero when present.`
`312`		`- int64 up_to = 1;`
	`312`	`+ google.protobuf.Int64Value up_to = 1;`
`313`	`313`	`}`
`314`	`314`
`315`	`315`	`// The type of aggregation to perform, required.`
Original file line number	Diff line number	Diff line change
`@@ -2427,7 +2427,7 @@`
`2427`	`2427`	`"Count": {`
`2428`	`2428`	`"fields": {`
`2429`	`2429`	`"upTo": {`
`2430`		`- "type": "int32",`
	`2430`	`+ "type": "google.protobuf.Int64Value",`
`2431`	`2431`	`"id": 1`
`2432`	`2432`	`}`
`2433`	`2433`	`}`