resolve comments

milaGGL · milaGGL · commit 0267c6947192 · 2022-09-16T11:43:22.000-07:00
diff --git a/.changeset/hot-insects-wink.md b/.changeset/hot-insects-wink.md
@@ -2,4 +2,4 @@
 '@firebase/firestore': minor
 ---
 
-Release count query for internal use.
+Implement count query for internal use.
diff --git a/packages/firestore/src/core/firestore_client.ts b/packages/firestore/src/core/firestore_client.ts
@@ -525,9 +525,10 @@ export function firestoreClientRunCountQuery(
             'Failed to get count result because the client is offline.'
           )
         );
+      } else {
+        const result = await getCount(query);
+        deferred.resolve(result);
       }
-      const result = await getCount(query);
-      deferred.resolve(result);
     } catch (e) {
       deferred.reject(e as Error);
     }

Original file line number	Diff line number	Diff line change
`@@ -525,9 +525,10 @@ export function firestoreClientRunCountQuery(`
`525`	`525`	`'Failed to get count result because the client is offline.'`
`526`	`526`	`)`
`527`	`527`	`);`
	`528`	`+ } else {`
	`529`	`+ const result = await getCount(query);`
	`530`	`+ deferred.resolve(result);`
`528`	`531`	`}`
`529`		`- const result = await getCount(query);`
`530`		`- deferred.resolve(result);`
`531`	`532`	`} catch (e) {`
`532`	`533`	`deferred.reject(e as Error);`
`533`	`534`	`}`