Skip to content

[#11887] Removed NSLog Calls from FirebaseAuth#12249

Merged
paulb777 merged 2 commits intofirebase:mainfrom
yakovmanshin:11887-removed-NSLog-from-FirebaseAuth
Jan 9, 2024
Merged

[#11887] Removed NSLog Calls from FirebaseAuth#12249
paulb777 merged 2 commits intofirebase:mainfrom
yakovmanshin:11887-removed-NSLog-from-FirebaseAuth

Conversation

@yakovmanshin
Copy link
Copy Markdown
Contributor

[Closes #11887]

  • Replaced NSLog calls in FIRTOTPSecret.m and FIRAuthRecaptchaVerifier.m with FIRLogger invocations
  • This commit introduces message codes I-AUT000023, I-AUT000024, I-AUT000025, I-AUT000026, I-AUT000027, I-AUT000028, I-AUT000029, I-AUT000030, and I-AUT000031

* Replaced `NSLog` calls in `FIRTOTPSecret.m` and `FIRAuthRecaptchaVerifier.m` with `FIRLogger` invocations
* This commit introduces message codes `I-AUT000023`, `I-AUT000024`, `I-AUT000025`, `I-AUT000026`, `I-AUT000027`, `I-AUT000028`, `I-AUT000029`, `I-AUT000030`, and `I-AUT000031`
Copy link
Copy Markdown
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment thread FirebaseAuth/Sources/Utilities/FIRAuthRecaptchaVerifier.m Outdated
Comment thread FirebaseAuth/Sources/Utilities/FIRAuthRecaptchaVerifier.m Outdated
@yakovmanshin yakovmanshin requested a review from paulb777 January 7, 2024 15:20
@paulb777 paulb777 requested a review from renkelvin January 7, 2024 15:28
@paulb777 paulb777 added this to the 10.20.0 - M142 milestone Jan 7, 2024
@paulb777 paulb777 merged commit 3e147e8 into firebase:main Jan 9, 2024
@yakovmanshin yakovmanshin deleted the 11887-removed-NSLog-from-FirebaseAuth branch January 9, 2024 16:51
@firebase firebase locked and limited conversation to collaborators Feb 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove NSLog from FirebaseAuth

3 participants