Skip to content

Firestore: Add test that verifies aggregate query error message when missing index#12189

Merged
dconeybe merged 11 commits intomasterfrom
dconeybe/CountMissingIndexErrorMessageTest
Dec 15, 2023
Merged

Firestore: Add test that verifies aggregate query error message when missing index#12189
dconeybe merged 11 commits intomasterfrom
dconeybe/CountMissingIndexErrorMessageTest

Conversation

@dconeybe
Copy link
Copy Markdown
Contributor

@dconeybe dconeybe commented Dec 12, 2023 •
edited
Loading

This verifies that the descriptive error message that occurs when the server does not have the required index has the URL that customers can follow to create the index.

This is a port of the "getCountFromServer error message is good if missing index" integration test from https://github.com/firebase/firebase-js-sdk/blob/42bfb0b8243a6c36b66a0bbedf61436e70591062/packages/firestore/test/integration/api/aggregation.test.ts#L130-L155 and firebase/firebase-android-sdk#4232.

Googlers see b/254063570 for details.

#no-changelog

@dconeybe dconeybe self-assigned this Dec 12, 2023
@dconeybe dconeybe mentioned this pull request Dec 12, 2023
Merged
@google-oss-bot
Copy link
Copy Markdown
Collaborator

google-oss-bot commented Dec 12, 2023 •
edited
Loading

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestoreInternal.framework

    Overall coverage changed from 88.16% (9f8909a) to 88.07% (6523ae7) by -0.09%.

    FilenameBase (9f8909a)Merge (6523ae7)Diff
    exception.cc84.21%23.68%-60.53%
    filesystem_posix.cc81.82%79.09%-2.73%
    leveldb_key.cc98.14%98.82%+0.69%
    leveldb_remote_document_cache.cc96.55%94.83%-1.72%
    ordered_code.cc94.39%93.90%-0.49%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/KNBuQ476KN.html

@dconeybe dconeybe changed the base branch from master to dconeybe/TimestampSkewFix December 12, 2023 21:18
Base automatically changed from dconeybe/TimestampSkewFix to master December 13, 2023 01:05
@google-oss-bot
Copy link
Copy Markdown
Collaborator

google-oss-bot commented Dec 14, 2023 •
edited
Loading

Size Report 1

Affected Products

  • FirebaseFirestore

    TypeBase (9f8909a)Merge (6523ae7)Diff
    CocoaPods-51.5 kB-51.5 kB-1 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/vYr4DW9Ne6.html

@dconeybe dconeybe changed the title Firestore: Add test that verifies count query error message when missing index Firestore: Add test that verifies aggregate query error message when missing index Dec 14, 2023
@dconeybe dconeybe marked this pull request as ready for review December 14, 2023 19:36
@dconeybe dconeybe requested a review from milaGGL December 14, 2023 19:36
milaGGL
milaGGL reviewed Dec 14, 2023
View reviewed changes
milaGGL
milaGGL approved these changes Dec 14, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@milaGGL milaGGL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

This was referenced Dec 14, 2023
Merged
Merged
@dconeybe dconeybe enabled auto-merge (squash) December 14, 2023 21:40
milaGGL
milaGGL approved these changes Dec 15, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@milaGGL milaGGL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dconeybe dconeybe merged commit a8264f0 into master Dec 15, 2023
@dconeybe dconeybe deleted the dconeybe/CountMissingIndexErrorMessageTest branch December 15, 2023 15:42
@dconeybe dconeybe mentioned this pull request Jan 8, 2024
Draft
@firebase firebase locked and limited conversation to collaborators Jan 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@milaGGL milaGGL milaGGL approved these changes

Assignees

@dconeybe dconeybe

Labels

api: firestore

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dconeybe @google-oss-bot @milaGGL