Updates firebaseApp check in makeDocumentSnapshot#80
Open
rharter wants to merge 1 commit intofirebase:masterfrom
Open
Updates firebaseApp check in makeDocumentSnapshot#80rharter wants to merge 1 commit intofirebase:masterfrom
firebaseApp check in makeDocumentSnapshot#80rharter wants to merge 1 commit intofirebase:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #79
Pretty self-explainatory, the optional property check is checking for a property called
app(like from RDB), but the firestore property is calledfirestoreApp.The existing work-around when you want to create a snapshot in your own app is to add both properties and cast: