Accept BooleanParams in CallableOptions#1854
Merged
wandamora merged 2 commits intofirebase:masterfrom Apr 2, 2026
Merged
Conversation
CallableOptions was not matching the same behavior as HttpsOptions, where app check env variables should be resolvable. This updates enforceAppCheck and consumeAppCheckToken to accept BooleanParams.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the CallableOptions interface to allow enforceAppCheck and consumeAppCheckToken to accept Expression<boolean> values in addition to standard booleans. It also updates the onCall handler logic to resolve these expressions correctly. The reviewer suggested simplifying the resolution logic for enforceAppCheck using the nullish coalescing operator to improve conciseness and future-proof the implementation.
wandamora
force-pushed
the
wm-fix-callable-options
branch
from
c3db75d to
a67c6c3
Compare
CallableOptions was not matching the same behavior as HttpsOptions, where app check env variables should be resolvable. This updates enforceAppCheck and consumeAppCheckToken to accept BooleanParams.
wandamora
force-pushed
the
wm-fix-callable-options
branch
from
a67c6c3 to
320b499
Compare
Contributor
|
@IzaakGough (I can't assign you as a reviewer properly yet) Can you review this please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CallableOptions was not matching the same behavior as HttpsOptions, where app check env variables should be resolvable. This updates enforceAppCheck and consumeAppCheckToken to accept BooleanParams.