Allow v2 auth blocking functions to use run.app or cf.net URLs#1831
Allow v2 auth blocking functions to use run.app or cf.net URLs#1831
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves an issue where Firebase Auth Blocking functions deployed as Cloud Functions v2 (GCFv2) were failing to verify tokens correctly when invoked from Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly allows v2 auth blocking functions to use either run.app or default cf.net URLs by inspecting the aud claim of the token before verification. This addresses an issue where run.app was always assumed for v2 functions. The implementation is sound, and I've added one suggestion to refactor a small part of the logic to improve code clarity and reduce duplication.
| if (handler.platform === "gcfv2" && unverified.aud && unverified.aud.includes("run.app")) { | ||
| decodedPayload = await auth.getAuth(getApp())._verifyAuthBlockingToken(req.body.data.jwt, "run.app"); | ||
| } else { | ||
| decodedPayload = await auth.getAuth(getApp())._verifyAuthBlockingToken(req.body.data.jwt); | ||
| } |
There was a problem hiding this comment.
This if/else block can be simplified to reduce code duplication. You can determine the audience first using a ternary operator and then make a single call to _verifyAuthBlockingToken. This makes the code more concise and easier to maintain.
const audience = (handler.platform === "gcfv2" && unverified.aud?.includes("run.app")) ? "run.app" : undefined;
decodedPayload = await auth.getAuth(getApp())._verifyAuthBlockingToken(req.body.data.jwt, audience);There was a problem hiding this comment.
Subjectively reads too complex to me. Will ignore.
There was a problem hiding this comment.
While the ternary looks too complex, I would say keeping an if for a const audience so that we only have one decodedPayload = await auth.getAuth(getApp())._verifyAuthBlockingToken(req.body.data.jwt, audience); looked like a good idea :)
4 participants
Fixes firebase/firebase-tools#9997