Include FDC custom scalar types with schema definition.#1814
Include FDC custom scalar types with schema definition.#1814rosalyntan merged 3 commits intomasterfrom
Conversation
Summary of ChangesHello @rosalyntan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the GraphQL server setup for Firebase Data Connect by automatically injecting a set of common FDC-specific custom scalar types into the schema. This enhancement simplifies schema definition for developers by providing built-in support for these data types, reducing boilerplate and improving consistency across FDC GraphQL implementations. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds support for Firebase Data Connect (FDC) custom scalar types by prepending them to the GraphQL schema. While this is a good feature, the current implementation could introduce a breaking change for users who have defined their own scalars with the same names. My main feedback is to make this feature opt-out to ensure backward compatibility. I've also included a suggestion to improve the readability and maintainability of how the new GraphQL scalars are defined.
Description
Add FDC custom scalar types (
Any,Void,Date, etc.) into the developers GraphQL schema definition, so developers do not need to redefine these scalars themselves.Code sample