Skip to content

Fix database double type precision bug #709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cynthiajoan merged 22 commits into from
Oct 27, 2021
Merged

Fix database double type precision bug #709

cynthiajoan merged 22 commits into from
Oct 27, 2021

Conversation

@cynthiajoan
Copy link
Contributor

@cynthiajoan cynthiajoan commented Oct 27, 2021 •
edited
Loading

Description

Make VariantToJson function able to record double type in 64bit
Fix firebase/quickstart-unity#1133

Testing

Test locally with integration test

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

Cynthia Jiang added 20 commits September 14, 2021 21:18
Fix the logic to generate .pro file
38f6fe8
update readme file
3697224
Merge https://github.com/firebase/firebase-cpp-sdk into feature/rc_re…
cb64a84 
…st_update
modify the release notes
e80ea39
Merge https://github.com/firebase/firebase-cpp-sdk into bugfix/fcm_token
642ddfc
Change the way to fetch initial token with the new API
fd9c129
Change the way to fetch initial token with the new API
18547d0
Add change to release notes
866b114
Update integration test to try out flaky reason.
0dd136a
Merge https://github.com/firebase/firebase-cpp-sdk into bugfix/fcm_token
c8c87a1
Format the file
19cc618
comment out new test to pass PR check first
50cd9bc
Merge https://github.com/firebase/firebase-cpp-sdk into bugfix/fcm_token
f17fe21
Merge https://github.com/firebase/firebase-cpp-sdk into bugfix/fcm_token
6d97911
Fix VariantToJson double data precision issue
a019937
format the code
270117f
add readme
6c2b7c7
restore messaging test
a2cacc4
Merge https://github.com/firebase/firebase-cpp-sdk into bugfix/database
1280b53
restore messaging integration test
70b2017
@cynthiajoan cynthiajoan requested a review from chkuang-g October 27, 2021 00:11
@google-cla google-cla bot added the cla: yes label Oct 27, 2021
@cynthiajoan cynthiajoan added the tests-requested: quick Trigger a quick set of integration tests. label Oct 27, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Oct 27, 2021
@github-actions
Copy link

github-actions bot commented Oct 27, 2021 •
edited
Loading

❌  Integration test FAILED

Requested by @cynthiajoan on commit 0201e94
Last updated: Wed Oct 27 18:50 PDT 2021
View integration test log & download artifacts

Failures Configs
messaging [TEST] [ERROR] [Android] [macos] [android_target]

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Oct 27, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Oct 27, 2021
chkuang-g
chkuang-g requested changes Oct 27, 2021
View reviewed changes
@cynthiajoan cynthiajoan requested a review from chkuang-g October 27, 2021 20:39
@cynthiajoan cynthiajoan merged commit 0201e94 into main Oct 27, 2021
@cynthiajoan cynthiajoan deleted the bugfix/database branch October 27, 2021 23:19
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests: failed This PR's integration tests failed. labels Oct 27, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Oct 28, 2021
@firebase firebase locked and limited conversation to collaborators Nov 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@chkuang-g chkuang-g chkuang-g approved these changes

Assignees

No one assigned

Labels

cla: yes tests: failed This PR's integration tests failed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] float and double data types saving problem

2 participants

@cynthiajoan @chkuang-g