Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
firebase-firestore/src/androidTest/java/com/google/firebase/firestore/PipelineTest.java
Show resolved
Hide resolved
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request successfully introduces support for the rand and trunc arithmetic pipeline expressions. The rand expression, previously internal, has been made public and an integration test has been added. The trunc expression, along with its truncToPrecision variants, has been fully integrated into the API and includes comprehensive test coverage. The api.txt file has been updated to reflect the new public methods and the appropriate @Beta annotations have been applied to new pipeline stages, indicating their experimental status. The CHANGELOG.md has also been updated to document these new features. The changes are well-aligned with the pull request description and demonstrate a clear implementation of the new functionality.
dlarocque
left a comment
dlarocque
left a comment
There was a problem hiding this comment.
It looks like this repo automatically dismisses reviews after changes are made :(
Approving again
…etalava Semver failure
3 participants
Adds support for the arithmetic pipeline expression
trunc.The
randexpression was already ported internally. Remove the internal keyword and add an integration test forrandexpressionported from firebase/firebase-js-sdk#9498