FIX: sort strings in UTF-8 encoded byte order#6615
Merged
Conversation
Contributor
Release note changesThe following release notes were modified. Please ensure they look correct. Release Notesfirebase-firestore### {{firestore}} version 25.1.2 {: #firestore_v25-1-2}
* {{fixed}} Fixed a server and sdk mismatch in unicode string sorting. GitHub [#6615](//github.com/firebase/firebase-android-sdk/issues/6615){: .external}
#### {{firestore}} Kotlin extensions version 25.1.2 {: #firestore-ktx_v25-1-2}
The Kotlin extensions library transitively includes the updated
`firebase-firestore` library. The Kotlin extensions library has no additional
updates.
|
Contributor
Vertex AI Mock Responses Check
|
Contributor
Test Results 186 files + 144 186 suites +144 4m 19s ⏱️ + 2m 57s Results for commit 4987548. ± Comparison against base commit b5dbd0a. This pull request removes 322 and adds 1234 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Collaborator
Coverage Report 1Affected Products
Test Logs
|
Collaborator
Size Report 1Affected Products
Test Logs
|
milaGGL
changed the title
ehsannas
approved these changes
Jan 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Strings should be sorted in UTF-8 encoded byte order. Public document: https://cloud.google.com/firestore/docs/concepts/data-types#data_types
SDK sorts strings using built in comparator method, which sorts lexicographically, and leads to mismatch between server and sdk when special characters are present. This PR fixes the string order mismatches on document field, map key, and document key.