Support deleteAllIndexes in PersistentCacheIndexManager#5162
Merged
cherylEnkidu merged 16 commits intomasterfrom Jul 27, 2023
Merged
Support deleteAllIndexes in PersistentCacheIndexManager#5162cherylEnkidu merged 16 commits intomasterfrom
cherylEnkidu merged 16 commits intomasterfrom
Conversation
Contributor
Unit Test Results 162 files - 642 162 suites - 642 2m 14s ⏱️ - 32m 59s Results for commit 74ba500. ± Comparison against base commit 2c8ab01. ♻️ This comment has been updated with latest results. |
Collaborator
Size Report 1Affected Products
Test Logs
|
cherylEnkidu
force-pushed
the
cheryllin/deleteAllIndexes
branch
from
aa0412a to
9d8ed0f
Compare
Collaborator
Coverage Report 1Affected Products
Test Logs |
dconeybe
reviewed
Jul 19, 2023
Contributor
dconeybe
left a comment
dconeybe
left a comment
There was a problem hiding this comment.
LGTM; however, I'll wait for someone more familiar with this code to give the formal LGTM.
wu-hui
reviewed
Jul 20, 2023
cherylEnkidu
force-pushed
the
cheryllin/deleteAllIndexes
branch
from
be31d91 to
4c7d5aa
Compare
dconeybe
requested changes
Jul 26, 2023
cherylEnkidu
force-pushed
the
cheryllin/deleteAllIndexes
branch
from
52cb627 to
74ba500
Compare
Contributor
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
Collaborator
Startup Time Report 1Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS. Notes
Startup Times
|
davidmotson
pushed a commit
that referenced
this pull request
Aug 3, 2023
* Add counter * address feedback 1 * implement autoClientIndexing * Add tests and fix bugs for BuildTargetIndex * hide getter from public API * move the flag from IndexManager to QueryEngine * move auto index flag to runtime * Support old way to enable persistent for PersistentCacheManager * Add hide and copyright * Rename PersistentCacheManager to PersistentCacheIndexManager * add configurable min documents to create indexes * Address feedback * Add deleteAllIndexes * Add documentation * add test coverage * merge main branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was ported to the web sdk in firebase/firebase-js-sdk#7587.