Remove some query restrictions and add integration tests#4231
Merged
Remove some query restrictions and add integration tests#4231
Conversation
Collaborator
Coverage Report 1Affected Products
Test Logs |
Collaborator
Size Report 1Affected Products
Test Logs
|
Contributor
Author
|
As expected, the newly added tests currently fail against prod |
wu-hui
reviewed
Oct 25, 2022
Contributor
wu-hui
left a comment
wu-hui
left a comment
There was a problem hiding this comment.
Can we have some tests to cover indexed queries as well?
ehsannas
force-pushed
the
ehsann/in-expansion-2
branch
from
3fa4785 to
9482fba
Compare
Collaborator
Generated by 🚫 Danger |
Contributor
Author
Do you mean the QueryTest integration test sets up an CSI similar to what's done in IndexingTest? FWIW, I've added the equivalent unit tests for CSI side here |
Contributor
Contributor
Author
|
Applying the "do not merge" label as relaxing these restrictions should not happen yet. |
cherylEnkidu
reviewed
Nov 1, 2022
firebase-firestore/src/androidTest/java/com/google/firebase/firestore/QueryTest.java
Outdated
Show resolved
Hide resolved
cherylEnkidu
reviewed
Nov 3, 2022
Contributor
cherylEnkidu
left a comment
cherylEnkidu
left a comment
There was a problem hiding this comment.
Last test in queriesInAndArrayContainsAnyArrayRules needs to be removed
Contributor
Author
|
@wu-hui would you please review the last commit? |
Collaborator
Startup Time Report 1Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS. Notes
Startup Times
|
wu-hui
approved these changes
Jan 31, 2023
firebase-firestore/src/androidTest/java/com/google/firebase/firestore/ValidationTest.java
Outdated
Show resolved
Hide resolved
Contributor
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. Add the 'main-merge-ack' label to your PR to confirm merging into the main branch is intended. |
MarkDuckworth
approved these changes
Feb 15, 2023
firebase-firestore/src/main/java/com/google/firebase/firestore/core/Query.java
Show resolved
Hide resolved
firebase-firestore/src/androidTest/java/com/google/firebase/firestore/QueryTest.java
Show resolved
Hide resolved
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR actually removes the restrictions and adds integration tests (which are expected to fail at this time).