Skip to content

Fix appcheck-ktx doc generation#4142

Merged
vkryachko merged 1 commit intomasterfrom
daymon-add-appcheck-ktx-to-package-list
Sep 23, 2022
Merged

Fix appcheck-ktx doc generation#4142
vkryachko merged 1 commit intomasterfrom
daymon-add-appcheck-ktx-to-package-list

Conversation

@daymxn
Copy link
Copy Markdown
Member

@daymxn daymxn commented Sep 23, 2022

In accordance with b/248593457, this fixes the incorrect output from running Dackka on appcheck-ktx. The package-summary url was missing the expected firebase.google.com prefix for translation. Since the artifact is new, it wasn't included in the previous package list. This PR adds it to the file, and the docs compile as expected.

@google-oss-bot
Copy link
Copy Markdown
Collaborator

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@vkryachko vkryachko merged commit c1fe187 into master Sep 23, 2022
@vkryachko vkryachko deleted the daymon-add-appcheck-ktx-to-package-list branch September 23, 2022 19:48
@google-oss-bot
Copy link
Copy Markdown
Collaborator

Coverage Report 1

Affected Products

  • firebase-messaging

    Overall coverage changed from ? (7273b29) to 85.38% (24dc52b) by ?.

    41 individual files with coverage change

    FilenameBase (7273b29)Merge (24dc52b)Diff
    AutoProtoEncoderDoNotUseEncoder.java?98.17%?
    ByteStreams.java?59.72%?
    CommonNotificationBuilder.java?90.78%?
    Constants.java?92.86%?
    DisplayNotification.java?91.38%?
    EnhancedIntentService.java?76.60%?
    ExecutorFactory.java?0.00%?
    FcmBroadcastProcessor.java?93.33%?
    FcmExecutors.java?80.00%?
    FcmLifecycleCallbacks.java?89.29%?
    FirebaseInstanceIdReceiver.java?72.73%?
    FirebaseMessaging.java?76.21%?
    FirebaseMessagingRegistrar.java?100.00%?
    FirebaseMessagingService.java?94.03%?
    GmsRpc.java?83.15%?
    ImageDownload.java?93.33%?
    MessagingAnalytics.java?82.19%?
    MessagingClientEvent.java?93.58%?
    MessagingClientEventExtension.java?76.47%?
    Metadata.java?61.90%?
    NotificationParams.java?98.71%?
    PoolableExecutors.java?29.17%?
    ProtoEncoderDoNotUse.java?50.00%?
    ProxyNotificationInitializer.java?93.75%?
    ProxyNotificationPreferences.java?88.89%?
    RemoteMessage.java?95.48%?
    RemoteMessageCreator.java?88.89%?
    RequestDeduplicator.java?90.00%?
    SendException.java?100.00%?
    ServiceStarter.java?87.50%?
    SharedPreferencesQueue.java?98.65%?
    Store.java?74.19%?
    SyncTask.java?70.83%?
    ThreadPriority.java?100.00%?
    TopicOperation.java?90.00%?
    TopicsStore.java?100.00%?
    TopicsSubscriber.java?89.47%?
    TopicsSyncTask.java?53.33%?
    WakeLockHolder.java?96.08%?
    WithinAppServiceBinder.java?90.91%?
    WithinAppServiceConnection.java?84.15%?

  • firebase-perf

    Overall coverage changed from 71.22% (7273b29) to 71.23% (24dc52b) by +0.02%.

    FilenameBase (7273b29)Merge (24dc52b)Diff
    RateLimiter.java90.77%91.54%+0.77%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/BGqLY8yQQe.html

@firebase firebase locked and limited conversation to collaborators Oct 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants