Add names to all Firebase components#4117
Merged
Conversation
Collaborator
Size Report 1Affected Products
Test Logs
|
Contributor
Collaborator
Coverage Report 1Affected Products
Test Logs
|
vkryachko
reviewed
Sep 21, 2022
| */ | ||
| @KeepForSdk | ||
| public class FirebaseAppCheckDebugRegistrar implements ComponentRegistrar { | ||
| public static final String LIBRARY_NAME = "fire-app-check-debug"; |
Member
There was a problem hiding this comment.
nit, here and throughout
Suggested change
| public static final String LIBRARY_NAME = "fire-app-check-debug"; | |
| private static final String LIBRARY_NAME = "fire-app-check-debug"; |
Contributor
Author
There was a problem hiding this comment.
Changed all constants to be private. Can you help me take another look?
vkryachko
approved these changes
Sep 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.