Add strict mode testing in firebase-messaging#4095
Merged
emilypgoogle merged 1 commit intomasterfrom Sep 23, 2022
Merged
Conversation
Collaborator
Generated by 🚫 Danger |
Collaborator
Coverage Report 1Affected ProductsNo changes between base commit (0c11f12) and merge commit (21d995a).Test Logs
|
Contributor
Collaborator
Size Report 1Affected Products
Test Logs |
Contributor
|
Just to clarify, this isn't actually resolving any strict mode violations, right? This appears to be adding a new test to prevent any new strict mode violations from being added in the future? If so, could you change the commit message to reflect that? I'm slightly concerned that someone just looking at the commit messages could think that there was a problem before and misdiagnose a strict mode issue, believing that it was caused by FCM and not identifying the actual cause. |
emilypgoogle
changed the title
Contributor
Author
|
Firebase squashes commits so I changed the PR name and it'll use that instead of what I used for my branch |
gsakakihara
approved these changes
Sep 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of a larger effort to resolve and prevent strict mode violations for eager components.