Revamp test harness for macrobenchmark tests#4071
Merged
Conversation
Contributor
yifanyang
commented
Sep 9, 2022
yifanyang
commented
- Upgrade Gradle version to 7.5.1
- Upgrade Android Gradle plugin version to 7.2.2
- Support trace collection for custom event
- Support building and running tests manually
Contributor
Collaborator
Coverage Report 1Affected Products
Test Logs
|
Collaborator
Size Report 1Affected ProductsNo changes between base commit (65356d8) and merge commit (1b84bbf).Test Logs
|
vkryachko
reviewed
Sep 19, 2022
Comment on lines
+104
to
+105
| # Adding an empty android app for baseline comparison | ||
| config['test-apps'].insert(0, {'sdk': 'baseline', 'name': 'baseline'}) |
Member
There was a problem hiding this comment.
Since we are now measuring Firebase traces only, do we still need this baseline to be present?
Contributor
Author
There was a problem hiding this comment.
Makes sense. Removed it and the reference to it in the README.
vkryachko
approved these changes
Sep 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.