Skip to content

Removing getRunningAppProcesses since the process_name isn't used#4057

Merged
raymondlam merged 1 commit intofirebase:masterfrom
raymondlam:removeGetRunningAppProcesses
Sep 15, 2022
Merged

Removing getRunningAppProcesses since the process_name isn't used#4057
raymondlam merged 1 commit intofirebase:masterfrom
raymondlam:removeGetRunningAppProcesses

Conversation

@raymondlam
Copy link
Copy Markdown
Member

getRunningAppProcesses() was also causing compliance issues with Tencent's appstore #4045

@raymondlam
Copy link
Copy Markdown
Member Author

/retest

Copy link
Copy Markdown
Contributor

@jeremyjiang-dev jeremyjiang-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@jeremyjiang-dev
Copy link
Copy Markdown
Contributor

The failing unit test seems to be flaky

@raymondlam
Copy link
Copy Markdown
Member Author

/retest

Copy link
Copy Markdown
Contributor

@visumickey visumickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these changes!

@raymondlam
Copy link
Copy Markdown
Member Author

/retest

@raymondlam raymondlam force-pushed the removeGetRunningAppProcesses branch from d1e5c88 to 4cd15cc Compare September 15, 2022 19:48
@raymondlam raymondlam merged commit 6df92b9 into firebase:master Sep 15, 2022
@raymondlam raymondlam deleted the removeGetRunningAppProcesses branch October 11, 2022 16:50
@firebase firebase locked and limited conversation to collaborators Oct 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants