add coroutines-play-services as a transitive dep to firebase-common-ktx#4044
add coroutines-play-services as a transitive dep to firebase-common-ktx#4044thatfiredev merged 7 commits intomasterfrom
Conversation
Size Report 1Affected Products
Test Logs
|
|
I'm slightly concerned with the increased size shown in the bot report above. Seems like adding the library as a transitive dependency adds ~390kB to every ktx module - to me it is a big bump for such a small addition. Update: No size difference, probably because we're including the library anyway. I'll proceed with the size bump, I guess that's the price to pay to get coroutines support out of the box. |
Coverage Report 1Affected Products
Test Logs
|
This reverts commit eea8af6.
thatfiredev
changed the title
|
|
…-sdk into rpf-add-coroutines-common-ktx � Conflicts: � build.gradle
firebase-common/ktx/src/test/kotlin/com/google/firebase/ktx/Tests.kt
Outdated
Show resolved
Hide resolved
|
@vkryachko Can I merge this? Also since it bumps firebase-common, does it mean we'll have to release all SDKs? Or only the ones that have methods returning Tasks? |
|
Sure, go ahead and merge. Yeah, we will have to release everyone with tasks. Can you coordinate with @VinayGuthal on the release? |
|
@vkryachko will do. Thanks! |
|
@vkryachko GitHub won't let me merge this, it says "Required statuses must pass before merging", I'm not sure why. |
You should click "Rerun failed jobs" inside the failed workflow |
…-sdk into rpf-add-coroutines-common-ktx
|
@vkryachko I checked the logs and noticed that the failing check was the flaky test which got fixed recently. I just had to sync with master, thanks for pointing me in the right direction. |
3 participants
(Googlers see go/suspend-ktx-firebase-android)