Merged
Conversation
There is one adoption blocker for now, so this change will be on a branch until it's addressed. Namely, we have to migrate to the new version of Dokka as our old version is not compatible with Gradle 7+.
Collaborator
Coverage Report 1Affected Products
Test Logs
|
Contributor
Collaborator
Size Report 1Affected Products
Test Logs
|
Contributor
It looks like AGP has stopped "transforming" test classes, so switching to Provider instead of `dagger.Lazy` to avoid the problem. It's not an issue since the injected class is has FirebaseAppScope(which is singleton-like).
Contributor
|
/test smoke-tests |
Collaborator
|
@vkryachko: The following test failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Collaborator
Generated by 🚫 Danger |
vkryachko
force-pushed
the
vk.agp_7.2
branch
from
64d58ba to
7be45bc
Compare
thatfiredev
reviewed
Sep 13, 2022
| distributionBase=GRADLE_USER_HOME | ||
| distributionPath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-6.9-bin.zip | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-7.3.3-all.zip |
Member
There was a problem hiding this comment.
Do we really need all or would bin suffice here?
rlazo
approved these changes
Sep 13, 2022
encoders/protoc-gen-firebase-encoders/protoc-gen-firebase-encoders.gradle
Outdated
Show resolved
Hide resolved
thatfiredev
reviewed
Sep 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.