Add info text argument to startFeedback#3971
Conversation
lfkellogg
force-pushed
the
fad-in-app-feedback
branch
from
91b3148 to
734d6ae
Compare
|
|
||
| private FeedbackSender feedbackSender; | ||
| private String releaseName; | ||
| private CharSequence infoText; |
There was a problem hiding this comment.
Just curious, how do you choose CharSequence instead of a plain ole' String?
There was a problem hiding this comment.
Because that's what Context.getText() returns: https://developer.android.com/reference/android/content/Context#getText(int)
Context.getString() returns a String but it does not retain any html/styles, which we need.
| public void startFeedback() { | ||
| startFeedback(Executors.newSingleThreadExecutor()); | ||
| public void startFeedback(int infoTextResourceId) { | ||
| startFeedbackWithInfoText(firebaseApp.getApplicationContext().getText(infoTextResourceId)); |
There was a problem hiding this comment.
Can you chain to startFeedback(String) instead of directly to startFeedbackWithInfoText, so the implementations are less likely to diverge?
There was a problem hiding this comment.
Actually I'm realizing our API should have startFeedback(CharSequence), so yes.
I was trying to model our API after TextView.setText, which accepts an int or a CharSequence. I thought it was int or String.
Coverage Report 1Affected Products
Test Logs
Notes |
| xmlns:tools="http://schemas.android.com/tools" | ||
| android:layout_width="match_parent" | ||
| android:layout_height="match_parent" | ||
| android:padding="24dp" |
There was a problem hiding this comment.
Is this just generated XML changes? I kind of just skimmed this.
There was a problem hiding this comment.
These add the info text to our proof-of-concept UX.
|
The public api surface has changed for the subproject firebase-appdistribution-api: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
|
The public api surface has changed for the subproject firebase-appdistribution-api: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
Size Report 1Affected Products
Test Logs
Notes |
|
The public api surface has changed for the subproject firebase-appdistribution-api: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
|
The public api surface has changed for the subproject firebase-appdistribution-api: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
|
/test smoke-tests |
3 participants
Based on go/iaf-sdk-api-proposal
Tested in test app:
