Skip to content

Rename collectAndSendFeedback to startFeedback#3932

Merged
lfkellogg merged 1 commit intofad-in-app-feedbackfrom
lk/start-feedback
Jul 21, 2022
Merged

Rename collectAndSendFeedback to startFeedback#3932
lfkellogg merged 1 commit intofad-in-app-feedbackfrom
lk/start-feedback

Conversation

@lfkellogg
Copy link
Copy Markdown
Contributor

Based on API council review feedback.

@github-actions
Copy link
Copy Markdown
Contributor

Unit Test Results

150 tests   150 ✔️  44s ⏱️
  17 suites      0 💤
  17 files        0

Results for commit f4f9a58.

@google-oss-bot
Copy link
Copy Markdown
Collaborator

Coverage Report 1

Affected Products

No changes between base commit (c5dc461) and merge commit (b88efff).

Test Logs

Notes

  • Commit (b88efff) is created by Prow via merging PR base commit (c5dc461) and head commit (f4f9a58).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/YqgWao4SPo.html

@google-oss-bot
Copy link
Copy Markdown
Collaborator

Size Report 1

Affected Products

  • firebase-appdistribution

    TypeBase (c5dc461)Merge (b88efff)Diff
    aar157 kB157 kB-3 B (-0.0%)
    apk (release)2.01 MB2.01 MB+52 B (+0.0%)
  • firebase-appdistribution-api

    TypeBase (c5dc461)Merge (b88efff)Diff
    aar14.5 kB14.5 kB-28 B (-0.2%)
    apk (release)697 kB697 kB-24 B (-0.0%)

Test Logs

Notes

  • Commit (b88efff) is created by Prow via merging PR base commit (c5dc461) and head commit (f4f9a58).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/b2a49329Sz.html

@lfkellogg lfkellogg merged commit a51698e into fad-in-app-feedback Jul 21, 2022
@lfkellogg lfkellogg deleted the lk/start-feedback branch July 21, 2022 19:08
@firebase firebase locked and limited conversation to collaborators Aug 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants