Skip to content

Remove In-App Feedback functionality from firebase-appdistribution#3926

Merged
lfkellogg merged 2 commits intomasterfrom
lk/remove-in-app-feedback
Jul 20, 2022
Merged

Remove In-App Feedback functionality from firebase-appdistribution#3926
lfkellogg merged 2 commits intomasterfrom
lk/remove-in-app-feedback

Conversation

@lfkellogg
Copy link
Copy Markdown
Contributor

@lfkellogg lfkellogg commented Jul 20, 2022

This gets the new feature off of the master branch so we can continue development in a new feature branch while allowing us to ship changes to the released SDK.

@lfkellogg lfkellogg requested review from jladieu and kaibolay July 20, 2022 17:15
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 20, 2022 •
edited
Loading

Unit Test Results

135 tests   - 9   135 ✔️  - 9   44s ⏱️ +14s
  14 suites  - 2       0 💤 ±0 
  14 files    - 2       0 ❌ ±0 

Results for commit 68ff11e. ± Comparison against base commit 5991287.

This pull request removes 15 and adds 6 tests. Note that renamed tests count towards both. 
com.google.firebase.appdistribution.impl.FeedbackSenderTest ‑ sendFeedback_attachScreenshotFails_failsTask
com.google.firebase.appdistribution.impl.FeedbackSenderTest ‑ sendFeedback_commitFeedbackFails_failsTask
com.google.firebase.appdistribution.impl.FeedbackSenderTest ‑ sendFeedback_createFeedbackFails_failsTask
com.google.firebase.appdistribution.impl.FeedbackSenderTest ‑ sendFeedback_success
com.google.firebase.appdistribution.impl.FeedbackSenderTest ‑ sendFeedback_withoutScreenshot_success
com.google.firebase.appdistribution.impl.FirebaseAppDistributionServiceImplTest ‑ collectAndSendFeedback_signsInTesterAndStartsActivity
com.google.firebase.appdistribution.impl.ImageUtilsTest ‑ readScaledImage_doesntExist_throws
com.google.firebase.appdistribution.impl.ImageUtilsTest ‑ readScaledImage_targetExactlyPowerOfTwoSmaller_scalesDown
com.google.firebase.appdistribution.impl.ImageUtilsTest ‑ readScaledImage_targetHeightIsSmaller_scalesDownToFitWidth
com.google.firebase.appdistribution.impl.ImageUtilsTest ‑ readScaledImage_targetIsGreaterThanHalf_returnsOriginal
…

com.google.firebase.appdistribution.internal.FirebaseAppDistributionProxyTest ‑ checkForNewRelease_failsWithNotImplemented
com.google.firebase.appdistribution.internal.FirebaseAppDistributionProxyTest ‑ isTesterSignedIn_returnsFalse
com.google.firebase.appdistribution.internal.FirebaseAppDistributionProxyTest ‑ signInTester_failsWithNotImplemented
com.google.firebase.appdistribution.internal.FirebaseAppDistributionProxyTest ‑ signOutTester_doesNotThrow
com.google.firebase.appdistribution.internal.FirebaseAppDistributionProxyTest ‑ updateApp
com.google.firebase.appdistribution.internal.FirebaseAppDistributionProxyTest ‑ updateIfNewReleaseAvailable

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Copy Markdown
Collaborator

google-oss-bot commented Jul 20, 2022 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-appdistribution

    Overall coverage changed from 76.79% (5991287) to 79.31% (8bd3097) by +2.53%.

    FilenameBase (5991287)Merge (8bd3097)Diff
    FirebaseAppDistributionImpl.java92.79%94.90%+2.11%
    FirebaseAppDistributionRegistrar.java81.08%92.59%+11.51%

  • firebase-appdistribution-api

    Overall coverage changed from 62.62% (5991287) to 64.42% (8bd3097) by +1.81%.

    FilenameBase (5991287)Merge (8bd3097)Diff
    FirebaseAppDistributionProxy.java84.62%100.00%+15.38%
    FirebaseAppDistributionStub.java81.40%83.33%+1.94%

Test Logs

Notes

  • Commit (8bd3097) is created by Prow via merging PR base commit (5991287) and head commit (68ff11e).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/N1kDNBE3Pq.html

@google-oss-bot
Copy link
Copy Markdown
Collaborator

google-oss-bot commented Jul 20, 2022

The public api surface has changed for the subproject firebase-appdistribution-api:
error: Removed method com.google.firebase.appdistribution.FirebaseAppDistribution.collectAndSendFeedback() [RemovedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@lfkellogg lfkellogg force-pushed the lk/remove-in-app-feedback branch from e5a542b to 6088401 Compare July 20, 2022 17:22
@google-oss-bot
Copy link
Copy Markdown
Collaborator

google-oss-bot commented Jul 20, 2022 •
edited
Loading

Size Report 1

Affected Products

  • firebase-appdistribution

    TypeBase (5991287)Merge (8bd3097)Diff
    aar157 kB145 kB-11.7 kB (-7.5%)
    apk (aggressive)880 kB776 kB-104 kB (-11.8%)
    apk (release)2.01 MB2.00 MB-6.43 kB (-0.3%)

  • firebase-appdistribution-api

    TypeBase (5991287)Merge (8bd3097)Diff
    aar14.5 kB14.4 kB-93 B (-0.6%)
    apk (release)697 kB697 kB-148 B (-0.0%)

Test Logs

Notes

  • Commit (8bd3097) is created by Prow via merging PR base commit (5991287) and head commit (68ff11e).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/qBODe3Rjtm.html

@google-oss-bot
Copy link
Copy Markdown
Collaborator

google-oss-bot commented Jul 20, 2022

The public api surface has changed for the subproject firebase-appdistribution-api:
error: Removed method com.google.firebase.appdistribution.FirebaseAppDistribution.collectAndSendFeedback() [RemovedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@lfkellogg lfkellogg force-pushed the lk/remove-in-app-feedback branch from 6088401 to a9cea9e Compare July 20, 2022 17:30
@google-oss-bot
Copy link
Copy Markdown
Collaborator

google-oss-bot commented Jul 20, 2022

The public api surface has changed for the subproject firebase-appdistribution-api:
error: Removed method com.google.firebase.appdistribution.FirebaseAppDistribution.collectAndSendFeedback() [RemovedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@lfkellogg lfkellogg merged commit 78d2888 into master Jul 20, 2022
@lfkellogg lfkellogg deleted the lk/remove-in-app-feedback branch July 20, 2022 18:11
lfkellogg added a commit that referenced this pull request Jul 20, 2022
@lfkellogg
Revert "Remove In-App Feedback functionality from firebase-appdistrib…
60919ee 
…ution (#3926)"

This reverts commit 78d2888.
lfkellogg added a commit that referenced this pull request Jul 20, 2022
@lfkellogg
Revert "Remove In-App Feedback functionality from firebase-appdistrib…
0f24df5 
…ution (#3926)" (#3927)

This reverts commit 78d2888.
lfkellogg added a commit that referenced this pull request Aug 5, 2022
@lfkellogg
Revert "Remove In-App Feedback functionality from firebase-appdistrib…
bd18723 
…ution (#3926)" (#3927)

This reverts commit 78d2888.
@firebase firebase locked and limited conversation to collaborators Aug 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kaibolay kaibolay Awaiting requested review from kaibolay

1 more reviewer

@jladieu jladieu jladieu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/XL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lfkellogg @google-oss-bot @jladieu