Skip to content

Add feedback button to app-distribution/test-app#3924

Merged
lfkellogg merged 1 commit intofad-in-app-feedbackfrom
lk/test-app-feedback
Jul 20, 2022
Merged

Add feedback button to app-distribution/test-app#3924
lfkellogg merged 1 commit intofad-in-app-feedbackfrom
lk/test-app-feedback

Conversation

@lfkellogg
Copy link
Copy Markdown
Contributor

@lfkellogg lfkellogg commented Jul 20, 2022

No description provided.

@lfkellogg lfkellogg requested review from jladieu and kaibolay July 20, 2022 15:21
@lfkellogg lfkellogg force-pushed the lk/test-app-feedback branch from 547b4fa to 0dfa97d Compare July 20, 2022 15:24
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 20, 2022 •
edited
Loading

Unit Test Results

   393 files     393 suites   17m 14s ⏱️
4 706 tests 4 681 ✔️ 22 💤 3 ❌
4 722 runs  4 697 ✔️ 22 💤 3 ❌

For more details on these failures, see this check.

Results for commit 9bca063.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Copy Markdown
Collaborator

google-oss-bot commented Jul 20, 2022 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.18% (0f24df5) to 50.23% (c6fd1b0) by +0.04%.

    FilenameBase (0f24df5)Merge (c6fd1b0)Diff
    ChildChangeAccumulator.java83.33%96.67%+13.33%

  • firebase-firestore

    Overall coverage changed from 45.85% (0f24df5) to 45.85% (c6fd1b0) by -0.00%.

    FilenameBase (0f24df5)Merge (c6fd1b0)Diff
    DeleteMutation.java95.24%90.48%-4.76%

  • firebase-perf

    Overall coverage changed from ? (0f24df5) to 71.38% (c6fd1b0) by ?.

    101 individual files with coverage change

    FilenameBase (0f24df5)Merge (c6fd1b0)Diff
    AddTrace.java?0.00%?
    AndroidApplicationInfo.java?34.71%?
    AndroidApplicationInfoOrBuilder.java?0.00%?
    AndroidLogger.java?100.00%?
    AndroidMemoryReading.java?38.36%?
    AndroidMemoryReadingOrBuilder.java?0.00%?
    ApplicationInfo.java?45.00%?
    ApplicationInfoOrBuilder.java?0.00%?
    ApplicationProcessState.java?73.91%?
    AppStartTrace.java?86.54%?
    AppStateMonitor.java?86.71%?
    AppStateUpdateHandler.java?92.86%?
    Clock.java?100.00%?
    ConfigResolver.java?97.38%?
    ConfigurationConstants.java?99.25%?
    ConfigurationFlag.java?100.00%?
    ConsoleUrlGenerator.java?37.50%?
    Constants.java?95.65%?
    Counter.java?90.91%?
    CpuGaugeCollector.java?92.77%?
    CpuMetricReading.java?39.33%?
    CpuMetricReadingOrBuilder.java?0.00%?
    DaggerFirebasePerformanceComponent.java?100.00%?
    DeviceCacheManager.java?76.03%?
    FirebasePerfApplicationInfoValidator.java?92.86%?
    FirebasePerfGaugeMetricValidator.java?100.00%?
    FirebasePerfHttpClient.java?93.85%?
    FirebasePerfMetricProto.java?0.00%?
    FirebasePerfNetworkValidator.java?86.67%?
    FirebasePerfOkHttpClient.java?44.90%?
    FirebasePerformance.java?79.12%?
    FirebasePerformanceAttributable.java?0.00%?
    FirebasePerformanceComponent.java?0.00%?
    FirebasePerformanceInitializer.java?33.33%?
    FirebasePerformanceModule.java?100.00%?
    FirebasePerformanceModule_ProvidesConfigResolverFactory.java?100.00%?
    FirebasePerformanceModule_ProvidesFirebaseAppFactory.java?100.00%?
    FirebasePerformanceModule_ProvidesFirebaseInstallationsFactory.java?100.00%?
    FirebasePerformanceModule_ProvidesRemoteConfigComponentFactory.java?100.00%?
    FirebasePerformanceModule_ProvidesRemoteConfigManagerFactory.java?100.00%?
    FirebasePerformanceModule_ProvidesSessionManagerFactory.java?100.00%?
    FirebasePerformanceModule_ProvidesTransportFactoryProviderFactory.java?100.00%?
    FirebasePerformance_Factory.java?100.00%?
    FirebasePerfProvider.java?76.92%?
    FirebasePerfRegistrar.java?100.00%?
    FirebasePerfTraceValidator.java?85.87%?
    FirebasePerfUrlConnection.java?44.26%?
    FlgTransport.java?83.33%?
    FragmentStateMonitor.java?94.87%?
    FrameMetricsCalculator.java?96.77%?
    FrameMetricsRecorder.java?78.38%?
    GaugeManager.java?98.43%?
    GaugeMetadata.java?32.21%?
    GaugeMetadataManager.java?84.21%?
    GaugeMetadataOrBuilder.java?0.00%?
    GaugeMetric.java?39.47%?
    GaugeMetricOrBuilder.java?0.00%?
    HttpMetric.java?92.65%?
    ImmutableBundle.java?100.00%?
    InstrHttpInputStream.java?92.86%?
    InstrHttpOutputStream.java?98.00%?
    InstrHttpsURLConnection.java?94.32%?
    InstrHttpURLConnection.java?93.42%?
    InstrumentApacheHttpResponseHandler.java?100.00%?
    InstrumentOkHttpEnqueueCallback.java?100.00%?
    InstrURLConnectionBase.java?94.86%?
    LogWrapper.java?23.08%?
    MemoryGaugeCollector.java?91.38%?
    NetworkConnectionInfo.java?0.00%?
    NetworkConnectionInfoOrBuilder.java?0.00%?
    NetworkRequestMetric.java?49.16%?
    NetworkRequestMetricBuilder.java?95.97%?
    NetworkRequestMetricBuilderUtil.java?75.00%?
    NetworkRequestMetricOrBuilder.java?0.00%?
    Optional.java?86.67%?
    PendingPerfEvent.java?100.00%?
    PerfMetric.java?33.67%?
    PerfMetricOrBuilder.java?0.00%?
    PerfMetricValidator.java?93.55%?
    PerfSession.java?93.22%?
    PerfSessionOrBuilder.java?0.00%?
    Rate.java?100.00%?
    RateLimiter.java?90.98%?
    RemoteConfigManager.java?92.86%?
    ResourceType.java?0.00%?
    ScreenTraceUtil.java?94.12%?
    SessionAwareObject.java?0.00%?
    SessionManager.java?100.00%?
    SessionVerbosity.java?68.42%?
    StorageUnit.java?57.89%?
    Timer.java?93.75%?
    Trace.java?96.67%?
    TraceMetric.java?43.14%?
    TraceMetricBuilder.java?100.00%?
    TraceMetricOrBuilder.java?0.00%?
    TransportInfo.java?0.00%?
    TransportInfoOrBuilder.java?0.00%?
    TransportManager.java?94.88%?
    URLAllowlist.java?94.44%?
    URLWrapper.java?0.00%?
    Utils.java?78.57%?

  • firebase-storage

    Overall coverage changed from 85.85% (0f24df5) to 86.24% (c6fd1b0) by +0.39%.

    FilenameBase (0f24df5)Merge (c6fd1b0)Diff
    StorageException.java65.45%69.09%+3.64%
    StorageTask.java84.29%84.89%+0.60%
    UploadTask.java80.58%82.37%+1.80%

Test Logs

Notes

  • Commit (c6fd1b0) is created by Prow via merging PR base commit (0f24df5) and head commit (9bca063).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/vmVaBfePJx.html

@google-oss-bot
Copy link
Copy Markdown
Collaborator

google-oss-bot commented Jul 20, 2022 •
edited
Loading

Size Report 1

Affected Products

  • base

    TypeBase (0f24df5)Merge (c6fd1b0)Diff
    apk (aggressive)?8.39 kB? (?)
    apk (release)?8.65 kB? (?)

  • firebase-abt

    TypeBase (0f24df5)Merge (c6fd1b0)Diff
    aar?14.0 kB? (?)
    apk (aggressive)?85.5 kB? (?)
    apk (release)?695 kB? (?)

  • firebase-annotations

    TypeBase (0f24df5)Merge (c6fd1b0)Diff
    apk (aggressive)?8.39 kB? (?)
    apk (release)?8.88 kB? (?)

  • firebase-appcheck

    TypeBase (0f24df5)Merge (c6fd1b0)Diff
    aar?37.6 kB? (?)
    apk (aggressive)?330 kB? (?)
    apk (release)?983 kB? (?)

  • firebase-appcheck-debug

    TypeBase (0f24df5)Merge (c6fd1b0)Diff
    aar?12.0 kB? (?)
    apk (aggressive)?331 kB? (?)
    apk (release)?987 kB? (?)

  • firebase-appcheck-debug-testing

    TypeBase (0f24df5)Merge (c6fd1b0)Diff
    aar?6.69 kB? (?)
    apk (aggressive)?332 kB? (?)
    apk (release)?1.02 MB? (?)

  • firebase-appcheck-interop

    TypeBase (0f24df5)Merge (c6fd1b0)Diff
    aar?5.45 kB? (?)
    apk (aggressive)?327 kB? (?)
    apk (release)?972 kB? (?)

  • firebase-appcheck-playintegrity

    TypeBase (0f24df5)Merge (c6fd1b0)Diff
    aar?10.5 kB? (?)
    apk (aggressive)?331 kB? (?)
    apk (release)?997 kB? (?)

  • firebase-appcheck-safetynet

    TypeBase (0f24df5)Merge (c6fd1b0)Diff
    aar?12.5 kB? (?)
    apk (aggressive)?331 kB? (?)
    apk (release)?998 kB? (?)

  • firebase-appdistribution

    TypeBase (0f24df5)Merge (c6fd1b0)Diff
    aar?157 kB? (?)
    apk (aggressive)?880 kB? (?)
    apk (release)?2.01 MB? (?)

  • firebase-appdistribution-api

    TypeBase (0f24df5)Merge (c6fd1b0)Diff
    aar?14.5 kB? (?)
    apk (aggressive)?85.5 kB? (?)
    apk (release)?697 kB? (?)

  • firebase-appdistribution-api-ktx

    TypeBase (0f24df5)Merge (c6fd1b0)Diff
    aar?6.13 kB? (?)
    apk (aggressive)?101 kB? (?)
    apk (release)?1.18 MB? (?)

  • firebase-common

    TypeBase (0f24df5)Merge (c6fd1b0)Diff
    aar?48.6 kB? (?)
    apk (aggressive)?84.8 kB? (?)
    apk (release)?690 kB? (?)

  • firebase-common-ktx

    TypeBase (0f24df5)Merge (c6fd1b0)Diff
    aar?6.28 kB? (?)
    apk (aggressive)?100 kB? (?)
    apk (release)?1.17 MB? (?)

  • firebase-components

    TypeBase (0f24df5)Merge (c6fd1b0)Diff
    aar?41.4 kB? (?)
    apk (aggressive)?8.68 kB? (?)
    apk (release)?29.5 kB? (?)

  • firebase-config

    TypeBase (0f24df5)Merge (c6fd1b0)Diff
    aar?63.3 kB? (?)
    apk (aggressive)?94.2 kB? (?)
    apk (release)?743 kB? (?)

  • firebase-config-ktx

    TypeBase (0f24df5)Merge (c6fd1b0)Diff
    aar?5.85 kB? (?)
    apk (aggressive)?114 kB? (?)
    apk (release)?1.22 MB? (?)

  • firebase-crashlytics

    TypeBase (0f24df5)Merge (c6fd1b0)Diff
    aar?341 kB? (?)
    apk (aggressive)?216 kB? (?)
    apk (release)?901 kB? (?)

  • firebase-crashlytics-ktx

    TypeBase (0f24df5)Merge (c6fd1b0)Diff
    aar?6.85 kB? (?)
    apk (aggressive)?232 kB? (?)
    apk (release)?1.38 MB? (?)

  • firebase-crashlytics-ndk

    TypeBase (0f24df5)Merge (c6fd1b0)Diff
    aar?1.68 MB? (?)
    apk (aggressive / arm64-v8a)?1.34 MB? (?)
    apk (aggressive / armeabi-v7a)?842 kB? (?)
    apk (aggressive / x86)?1.38 MB? (?)
    apk (aggressive / x86_64)?1.44 MB? (?)
    apk (release / arm64-v8a)?2.02 MB? (?)
    apk (release / armeabi-v7a)?1.53 MB? (?)
    apk (release / x86)?2.07 MB? (?)
    apk (release / x86_64)?2.13 MB? (?)

  • firebase-database

    TypeBase (0f24df5)Merge (c6fd1b0)Diff
    aar?488 kB? (?)
    apk (aggressive)?329 kB? (?)
    apk (release)?1.15 MB? (?)

  • firebase-database-collection

    TypeBase (0f24df5)Merge (c6fd1b0)Diff
    aar?34.1 kB? (?)
    apk (aggressive)?312 kB? (?)
    apk (release)?941 kB? (?)

  • firebase-database-ktx

    TypeBase (0f24df5)Merge (c6fd1b0)Diff
    aar?7.71 kB? (?)
    apk (aggressive)?349 kB? (?)
    apk (release)?1.63 MB? (?)

  • firebase-datatransport

    TypeBase (0f24df5)Merge (c6fd1b0)Diff
    aar?5.13 kB? (?)
    apk (aggressive)?131 kB? (?)
    apk (release)?778 kB? (?)

  • firebase-decoders-json

    TypeBase (0f24df5)Merge (c6fd1b0)Diff
    aar?7.52 kB? (?)
    apk (aggressive)?8.68 kB? (?)
    apk (release)?15.3 kB? (?)

  • firebase-dynamic-links

    TypeBase (0f24df5)Merge (c6fd1b0)Diff
    aar?53.3 kB? (?)
    apk (aggressive)?329 kB? (?)
    apk (release)?985 kB? (?)

  • firebase-dynamic-links-ktx

    TypeBase (0f24df5)Merge (c6fd1b0)Diff
    aar?8.79 kB? (?)
    apk (aggressive)?349 kB? (?)
    apk (release)?1.47 MB? (?)

  • firebase-dynamic-module-support

    TypeBase (0f24df5)Merge (c6fd1b0)Diff
    aar?5.88 kB? (?)
    apk (aggressive)?94.1 kB? (?)
    apk (release)?742 kB? (?)

  • firebase-encoders

    TypeBase (0f24df5)Merge (c6fd1b0)Diff
    apk (aggressive)?8.68 kB? (?)
    apk (release)?15.3 kB? (?)

  • firebase-encoders-json

    TypeBase (0f24df5)Merge (c6fd1b0)Diff
    aar?10.5 kB? (?)
    apk (aggressive)?8.68 kB? (?)
    apk (release)?20.1 kB? (?)

  • firebase-encoders-proto

    TypeBase (0f24df5)Merge (c6fd1b0)Diff
    apk (aggressive)?8.68 kB? (?)
    apk (release)?21.6 kB? (?)

  • firebase-encoders-reflective

    TypeBase (0f24df5)Merge (c6fd1b0)Diff
    aar?7.63 kB? (?)
    apk (aggressive)?8.68 kB? (?)
    apk (release)?22.2 kB? (?)

  • firebase-firestore

    TypeBase (0f24df5)Merge (c6fd1b0)Diff
    aar?1.26 MB? (?)
    apk (aggressive)?489 kB? (?)
    apk (release)?3.39 MB? (?)

  • firebase-firestore-ktx

    TypeBase (0f24df5)Merge (c6fd1b0)Diff
    aar?7.47 kB? (?)
    apk (aggressive)?505 kB? (?)
    apk (release)?3.87 MB? (?)

  • firebase-functions

    TypeBase (0f24df5)Merge (c6fd1b0)Diff
    aar?26.2 kB? (?)
    apk (aggressive)?397 kB? (?)
    apk (release)?1.22 MB? (?)

  • firebase-functions-ktx

    TypeBase (0f24df5)Merge (c6fd1b0)Diff
    aar?6.14 kB? (?)
    apk (aggressive)?413 kB? (?)
    apk (release)?1.70 MB? (?)

  • firebase-inappmessaging

    TypeBase (0f24df5)Merge (c6fd1b0)Diff
    aar?470 kB? (?)
    apk (aggressive)?664 kB? (?)
    apk (release)?3.43 MB? (?)

  • firebase-inappmessaging-display

    TypeBase (0f24df5)Merge (c6fd1b0)Diff
    aar?206 kB? (?)
    apk (aggressive)?1.50 MB? (?)
    apk (release)?4.69 MB? (?)

  • firebase-inappmessaging-display-ktx

    TypeBase (0f24df5)Merge (c6fd1b0)Diff
    aar?22.2 kB? (?)
    apk (aggressive)?1.51 MB? (?)
    apk (release)?5.18 MB? (?)

  • firebase-inappmessaging-ktx

    TypeBase (0f24df5)Merge (c6fd1b0)Diff
    aar?5.29 kB? (?)
    apk (aggressive)?680 kB? (?)
    apk (release)?3.91 MB? (?)

  • firebase-installations

    TypeBase (0f24df5)Merge (c6fd1b0)Diff
    aar?55.0 kB? (?)
    apk (aggressive)?86.4 kB? (?)
    apk (release)?712 kB? (?)

  • firebase-installations-interop

    TypeBase (0f24df5)Merge (c6fd1b0)Diff
    aar?8.34 kB? (?)
    apk (aggressive)?65.0 kB? (?)
    apk (release)?651 kB? (?)

  • firebase-installations-ktx

    TypeBase (0f24df5)Merge (c6fd1b0)Diff
    aar?5.28 kB? (?)
    apk (aggressive)?102 kB? (?)
    apk (release)?1.19 MB? (?)

  • firebase-messaging

    TypeBase (0f24df5)Merge (c6fd1b0)Diff
    aar?142 kB? (?)
    apk (aggressive)?438 kB? (?)
    apk (release)?1.15 MB? (?)

  • firebase-messaging-directboot

    TypeBase (0f24df5)Merge (c6fd1b0)Diff
    aar?9.21 kB? (?)
    apk (aggressive)?438 kB? (?)
    apk (release)?1.15 MB? (?)

  • firebase-messaging-ktx

    TypeBase (0f24df5)Merge (c6fd1b0)Diff
    aar?6.53 kB? (?)
    apk (aggressive)?454 kB? (?)
    apk (release)?1.63 MB? (?)

  • firebase-ml-modeldownloader

    TypeBase (0f24df5)Merge (c6fd1b0)Diff
    aar?87.6 kB? (?)
    apk (aggressive)?143 kB? (?)
    apk (release)?830 kB? (?)

  • firebase-ml-modeldownloader-ktx

    TypeBase (0f24df5)Merge (c6fd1b0)Diff
    aar?6.40 kB? (?)
    apk (aggressive)?159 kB? (?)
    apk (release)?1.31 MB? (?)

  • firebase-perf

    TypeBase (0f24df5)Merge (c6fd1b0)Diff
    aar?311 kB? (?)
    apk (aggressive)?1.03 MB? (?)
    apk (release)?2.48 MB? (?)

  • firebase-perf-ktx

    TypeBase (0f24df5)Merge (c6fd1b0)Diff
    aar?19.5 kB? (?)
    apk (aggressive)?1.04 MB? (?)
    apk (release)?2.96 MB? (?)

  • firebase-segmentation

    TypeBase (0f24df5)Merge (c6fd1b0)Diff
    aar?20.2 kB? (?)
    apk (aggressive)?86.9 kB? (?)
    apk (release)?719 kB? (?)

  • firebase-storage

    TypeBase (0f24df5)Merge (c6fd1b0)Diff
    aar?115 kB? (?)
    apk (aggressive)?328 kB? (?)
    apk (release)?1.01 MB? (?)

  • firebase-storage-ktx

    TypeBase (0f24df5)Merge (c6fd1b0)Diff
    aar?7.29 kB? (?)
    apk (aggressive)?348 kB? (?)
    apk (release)?1.50 MB? (?)

  • protolite-well-known-types

    TypeBase (0f24df5)Merge (c6fd1b0)Diff
    aar?1.00 MB? (?)
    apk (aggressive)?134 kB? (?)
    apk (release)?663 kB? (?)

  • transport-api

    TypeBase (0f24df5)Merge (c6fd1b0)Diff
    aar?6.57 kB? (?)
    apk (aggressive)?8.68 kB? (?)
    apk (release)?14.9 kB? (?)

  • transport-backend-cct

    TypeBase (0f24df5)Merge (c6fd1b0)Diff
    aar?53.5 kB? (?)
    apk (aggressive)?58.0 kB? (?)
    apk (release)?105 kB? (?)

  • transport-runtime

    TypeBase (0f24df5)Merge (c6fd1b0)Diff
    aar?178 kB? (?)
    apk (aggressive)?43.9 kB? (?)
    apk (release)?82.9 kB? (?)

Test Logs

Notes

  • Commit (c6fd1b0) is created by Prow via merging PR base commit (0f24df5) and head commit (9bca063).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/89S1XO09Dq.html

@lfkellogg lfkellogg force-pushed the lk/test-app-feedback branch 2 times, most recently from f10f295 to 7140fba Compare July 20, 2022 17:27
@lfkellogg lfkellogg changed the base branch from master to fad-in-app-feedback July 20, 2022 18:16
@lfkellogg lfkellogg force-pushed the lk/test-app-feedback branch from 7140fba to 9bca063 Compare July 20, 2022 19:06
@lfkellogg lfkellogg merged commit 53d9f61 into fad-in-app-feedback Jul 20, 2022
@lfkellogg lfkellogg deleted the lk/test-app-feedback branch July 20, 2022 20:02
lfkellogg added a commit that referenced this pull request Aug 5, 2022
@lfkellogg
Add feedback button to app-distribution/test-app (#3924)
8a3158b
@firebase firebase locked and limited conversation to collaborators Aug 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kaibolay kaibolay kaibolay approved these changes

+1 more reviewer

@jladieu jladieu jladieu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lfkellogg @google-oss-bot @jladieu @kaibolay