Fix synchronized wrong object while manipulating appColdStartSubscribers (#3992)

Knight-ZXW · web-flow · commit 3f132914ce6f · 2022-08-29T10:30:17.000-07:00
diff --git a/firebase-perf/src/main/java/com/google/firebase/perf/application/AppStateMonitor.java b/firebase-perf/src/main/java/com/google/firebase/perf/application/AppStateMonitor.java
@@ -290,7 +290,7 @@ public void unregisterForAppState(WeakReference<AppStateCallback> subscriber) {
    * @param subscriber the {@link AppColdStartCallback} instance.
    */
   public void registerForAppColdStart(AppColdStartCallback subscriber) {
-    synchronized (appStateSubscribers) {
+    synchronized (appColdStartSubscribers) {
       appColdStartSubscribers.add(subscriber);
     }
   }
@@ -315,7 +315,7 @@ private void updateAppState(ApplicationProcessState newState) {
 
   /** Send cold start update to registered subscribers. */
   private void sendAppColdStartUpdate() {
-    synchronized (appStateSubscribers) {
+    synchronized (appColdStartSubscribers) {
       for (Iterator<AppColdStartCallback> i = appColdStartSubscribers.iterator(); i.hasNext(); ) {
         AppColdStartCallback callback = i.next();
         if (callback != null) {
