better comments and added local RC lookup back

leotianlizhan · leotianlizhan · commit 0ae206b9bf3c · 2022-09-27T15:44:21.000-04:00
diff --git a/firebase-perf/src/main/java/com/google/firebase/perf/config/ConfigResolver.java b/firebase-perf/src/main/java/com/google/firebase/perf/config/ConfigResolver.java
@@ -772,7 +772,7 @@ public float getFragmentSamplingRate() {
   public boolean getIsExperimentTTIDEnabled() {
     // Order of precedence is:
     // 1. If the value exists in Android Manifest, return this value.
-    // 2. Cannot read value from RC because it's not initalized yet
+    // 2. If the value exists through Firebase Remote Config, cache and return this value.
     // 3. If the value exists in device cache, return this value.
     // 4. Otherwise, return default value.
     ExperimentTTID config = ExperimentTTID.getInstance();
@@ -783,7 +783,13 @@ public boolean getIsExperimentTTIDEnabled() {
       return metadataValue.get();
     }
 
-    // 2. Cannot read value from RC because it's not initialized yet.
+    // 2. Reads value from Firebase Remote Config, saves this value in cache layer if valid.
+    Optional<Boolean> rcValue = getRemoteConfigBoolean(config);
+    if (rcValue.isAvailable()) {
+      deviceCacheManager.setValue(config.getDeviceCacheFlag(), rcValue.get());
+      return rcValue.get();
+    }
+
     // 3. Reads value from cache layer.
     Optional<Boolean> deviceCacheValue = getDeviceCacheBoolean(config);
     if (deviceCacheValue.isAvailable()) {
diff --git a/firebase-perf/src/main/java/com/google/firebase/perf/config/RemoteConfigManager.java b/firebase-perf/src/main/java/com/google/firebase/perf/config/RemoteConfigManager.java
@@ -342,7 +342,9 @@ protected void syncConfigValues(Map<String, FirebaseRemoteConfigValue> newlyFetc
       }
     }
 
-    // Save to device cache upon successful RC fetchAndActivate
+    // TODO: remove after experiment is over and experiment RC flag is no longer needed
+    // Save ExperimentTTID flag to device cache upon successful RC fetchAndActivate, because reading
+    // is done quite early and it is possible that RC isn't initialized yet.
     ExperimentTTID flag = ExperimentTTID.getInstance();
     FirebaseRemoteConfigValue rcValue = allRcConfigMap.get(flag.getRemoteConfigFlag());
     if (rcValue != null) {

Original file line number	Diff line number	Diff line change
`@@ -342,7 +342,9 @@ protected void syncConfigValues(Map<String, FirebaseRemoteConfigValue> newlyFetc`
`342`	`342`	`}`
`343`	`343`	`}`
`344`	`344`
`345`		`- // Save to device cache upon successful RC fetchAndActivate`
	`345`	`+ // TODO: remove after experiment is over and experiment RC flag is no longer needed`
	`346`	`+ // Save ExperimentTTID flag to device cache upon successful RC fetchAndActivate, because reading`
	`347`	`+ // is done quite early and it is possible that RC isn't initialized yet.`
`346`	`348`	`ExperimentTTID flag = ExperimentTTID.getInstance();`
`347`	`349`	`FirebaseRemoteConfigValue rcValue = allRcConfigMap.get(flag.getRemoteConfigFlag());`
`348`	`350`	`if (rcValue != null) {`