Make infoText CharSequence non null

lfkellogg · lfkellogg · commit 07e9da8cda90 · 2022-08-08T14:39:04.000-04:00
diff --git a/firebase-appdistribution-api/api.txt b/firebase-appdistribution-api/api.txt
@@ -20,7 +20,7 @@ package com.google.firebase.appdistribution {
     method @NonNull public com.google.android.gms.tasks.Task<java.lang.Void> signInTester();
     method public void signOutTester();
     method public void startFeedback(int);
-    method public void startFeedback(CharSequence);
+    method public void startFeedback(@NonNull CharSequence);
     method @NonNull public com.google.firebase.appdistribution.UpdateTask updateApp();
     method @NonNull public com.google.firebase.appdistribution.UpdateTask updateIfNewReleaseAvailable();
   }
diff --git a/firebase-appdistribution-api/src/main/java/com/google/firebase/appdistribution/FirebaseAppDistribution.java b/firebase-appdistribution-api/src/main/java/com/google/firebase/appdistribution/FirebaseAppDistribution.java
@@ -139,7 +139,7 @@ public interface FirebaseAppDistribution {
    * @param infoText text to display to the tester before collecting feedback data (e.g. Terms and
    *     Conditions)
    */
-  void startFeedback(CharSequence infoText);
+  void startFeedback(@NonNull CharSequence infoText);
 
   /** Gets the singleton {@link FirebaseAppDistribution} instance. */
   @NonNull
diff --git a/firebase-appdistribution-api/src/main/java/com/google/firebase/appdistribution/internal/FirebaseAppDistributionProxy.java b/firebase-appdistribution-api/src/main/java/com/google/firebase/appdistribution/internal/FirebaseAppDistributionProxy.java
@@ -78,7 +78,7 @@ public void startFeedback(int infoTextResourceId) {
   }
 
   @Override
-  public void startFeedback(CharSequence infoText) {
+  public void startFeedback(@NonNull CharSequence infoText) {
     delegate.startFeedback(infoText);
   }
 }
diff --git a/firebase-appdistribution-api/src/main/java/com/google/firebase/appdistribution/internal/FirebaseAppDistributionStub.java b/firebase-appdistribution-api/src/main/java/com/google/firebase/appdistribution/internal/FirebaseAppDistributionStub.java
@@ -79,7 +79,7 @@ public void startFeedback(int infoTextResourceId) {
   }
 
   @Override
-  public void startFeedback(CharSequence infoText) {
+  public void startFeedback(@NonNull CharSequence infoText) {
     return;
   }
 
diff --git a/firebase-appdistribution/src/main/java/com/google/firebase/appdistribution/impl/FirebaseAppDistributionImpl.java b/firebase-appdistribution/src/main/java/com/google/firebase/appdistribution/impl/FirebaseAppDistributionImpl.java
@@ -314,7 +314,7 @@ public void startFeedback(int infoTextResourceId) {
   }
 
   @VisibleForTesting
-  public void startFeedback(CharSequence infoText) {
+  public void startFeedback(@NonNull CharSequence infoText) {
     screenshotTaker
         .takeScreenshot()
         .onSuccessTask(

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ package com.google.firebase.appdistribution {`
`20`	`20`	`method @NonNull public com.google.android.gms.tasks.Task<java.lang.Void> signInTester();`
`21`	`21`	`method public void signOutTester();`
`22`	`22`	`method public void startFeedback(int);`
`23`		`- method public void startFeedback(CharSequence);`
	`23`	`+ method public void startFeedback(@NonNull CharSequence);`
`24`	`24`	`method @NonNull public com.google.firebase.appdistribution.UpdateTask updateApp();`
`25`	`25`	`method @NonNull public com.google.firebase.appdistribution.UpdateTask updateIfNewReleaseAvailable();`
`26`	`26`	`}`
Original file line number	Diff line number	Diff line change
`@@ -78,7 +78,7 @@ public void startFeedback(int infoTextResourceId) {`
`78`	`78`	`}`
`79`	`79`
`80`	`80`	`@Override`
`81`		`- public void startFeedback(CharSequence infoText) {`
	`81`	`+ public void startFeedback(@NonNull CharSequence infoText) {`
`82`	`82`	`delegate.startFeedback(infoText);`
`83`	`83`	`}`
`84`	`84`	`}`
Original file line number	Diff line number	Diff line change
`@@ -79,7 +79,7 @@ public void startFeedback(int infoTextResourceId) {`
`79`	`79`	`}`
`80`	`80`
`81`	`81`	`@Override`
`82`		`- public void startFeedback(CharSequence infoText) {`
	`82`	`+ public void startFeedback(@NonNull CharSequence infoText) {`
`83`	`83`	`return;`
`84`	`84`	`}`
`85`	`85`
Original file line number	Diff line number	Diff line change
`@@ -314,7 +314,7 @@ public void startFeedback(int infoTextResourceId) {`
`314`	`314`	`}`
`315`	`315`
`316`	`316`	`@VisibleForTesting`
`317`		`- public void startFeedback(CharSequence infoText) {`
	`317`	`+ public void startFeedback(@NonNull CharSequence infoText) {`
`318`	`318`	`screenshotTaker`
`319`	`319`	`.takeScreenshot()`
`320`	`320`	`.onSuccessTask(`