Repository navigation
Conversation
demolaf
marked this pull request as draft
April 28, 2026 14:48
Coverage Report✅ Coverage 74.61% meets 40% threshold Total Coverage: 74.61% Package Breakdown
Minimum threshold: 40% |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request transitions the test suite from manual environment variable-based skipping to using Dart's native test tagging system. It introduces prod and wif tags to identify tests that require production APIs or Workload Identity Federation, respectively. The changes include adding dart_test.yaml configurations, applying tags to relevant test files and groups, and updating coverage scripts to handle these tags conditionally based on the presence of credentials. I have no feedback to provide.
Lyokone
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.