Fix #317: Clear field modified flag after reset/initialize#536
Merged
Conversation
When reset() or initialize() is called, the modified flag on fields wasn't being updated to reflect the new initialValues. Fix: After updating initialValues, recalculate the modified flag for each field by comparing current value with new initial value. Added tests verifying: - reset() clears modified flag - initialize() clears modified flag when value matches new initial value
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughThis PR adds two test files documenting FinalForm's field modified flag behavior during reset and async validation scenarios, and implements a fix in FinalForm.ts that recomputes each field's modified flag by comparing current values to initial values using the field's isEqual method after reinitialization. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
The fix to recalculate modified flags after initialize adds ~26 bytes. Small size increase is acceptable for fixing the bug.
erikras
approved these changes
Feb 17, 2026
Contributor
Author
|
Published in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: When
reset()orinitialize()is called, themodifiedflag on fields staystrueeven though the field value now matches the new initial value.Root Cause: The
initialize()function updatesformState.initialValuesandformState.values, but doesn't recalculate themodifiedflag for existing fields.Solution: After updating initial values, loop through all fields and recalculate their
modifiedflag by comparing current value with new initial value:modified = falsekeepDirtyOnReinitialize) →modified = trueTesting:
Fixes #317
Summary by CodeRabbit
Release Notes
Bug Fixes
Tests