Fix #166: Clear async validation promise on rejection to prevent infinite loop by erikras-gilfoyle-agent · Pull Request #530 · final-form/final-form

erikras-gilfoyle-agent · 2026-02-16T12:08:11Z

Problem: When an async validator returns a rejected promise (instead of throwing), the form gets stuck in an infinite submit loop because the validation promise is never cleared from the asyncValidationPromises object.

Root Cause: The .then() handler with clearAsyncValidationPromise only runs on successful resolution. When a promise rejects, the handler never executes, leaving the rejected promise in the tracking object. Each submit waits for this promise, catches the rejection, and recursively calls submit again - creating an infinite loop.

Solution: Added a .catch() handler that also calls clearAsyncValidationPromise before re-throwing the error. This ensures the promise is cleaned up regardless of whether it resolves or rejects.

Testing:

Added test that reproduces the infinite loop bug
Test verifies that:
- Form doesn't hang on submit with rejected promise
- Subsequent field changes can trigger validation again (promise was properly cleared)
- Error is logged to console as expected
All existing tests pass

Fixes #166

Summary by CodeRabbit

Bug Fixes
- Prevented form submissions from hanging when async validators reject; async validation state is now cleaned up on both success and failure so subsequent value changes trigger fresh validation instead of reusing a prior rejected state.
Tests
- Added a test ensuring rejected async validation does not cause hangs, logs the error, and that validation is retriggered correctly after value changes.

coderabbitai · 2026-02-16T12:08:27Z

No actionable comments were generated in the recent review. 🎉

📝 Walkthrough

Walkthrough

Adds cleanup for rejected promises from async validators so async validation promises are cleared on both resolve and reject, preventing infinite submit loops; adds a test ensuring submission does not hang when an async validator rejects and that validation reruns after a subsequent value change.

Changes

Cohort / File(s)	Summary
Async validation core `src/FinalForm.ts`	Adds a `.catch(...)` to the `Promise.all(promises)` chain that clears the async validation promise on rejection and rethrows, ensuring cleanup on both resolve and reject paths; attention: promise cleanup logic updated.
Submission test `src/FinalForm.submission.test.ts`	Adds a test verifying a rejected async validator does not hang submission, that the rejection is logged, and that a later value change triggers fresh validation (not reuse of the rejected promise).
Build metadata `package.json`	Increases bundle size limits for `dist/final-form.es.js` and `dist/final-form.cjs.js` (non-functional test/bundle config change).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Fix #482: Handle validation for both array and array items #524: Modifies FinalForm async validation internals; related to promise handling and async validation cleanup.

Suggested reviewers

erikras
erikras-richard-agent

Poem

🐰
A promise slipped, began to roam,
We chased its tail and brought it home.
No endless spin, no frozen page,
Validators cleared — the form's un-staged.
Hop, nibble, code — let's bound with glee!

🚥 Pre-merge checks | ✅ 5 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately and concisely summarizes the main change: fixing an infinite loop issue by clearing async validation promises on rejection.
Linked Issues check	✅ Passed	The PR successfully addresses all coding requirements from issue `#166`: handles rejected promises by adding a catch handler, prevents infinite loops through proper cleanup, and includes a test validating the fix.
Out of Scope Changes check	✅ Passed	All changes are directly related to fixing the infinite loop issue: the core fix in FinalForm.ts, test case in FinalForm.submission.test.ts, and minor bundle size adjustment in package.json are all in scope.
Merge Conflict Detection	✅ Passed	✅ No merge conflicts detected when merging into `main`

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch fix-166-rejected-promise-infinite-loop

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@src/FinalForm.submission.test.ts`:
- Line 1284: The variable callCountAfterChange is declared but never used;
remove the unused declaration to clean up the test. Locate the line that assigns
const callCountAfterChange = validationCallCount (and any immediate unused
references to callCountAfterChange) and delete that statement so the test relies
directly on validationCallCount or existing assertions instead of the dead
variable.

…nite loop - Added .catch() handler to clear async validation promise when rejected - Prevents infinite submit loop when async validators return rejected promises - Test verifies promise is cleared and validation can run again

codecov · 2026-02-16T12:28:16Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.75%. Comparing base (e1c30c1) to head (d0b0f64).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #530      +/-   ##
==========================================
- Coverage   99.05%   98.75%   -0.31%     
==========================================
  Files          13       13              
  Lines         849      882      +33     
  Branches      286      299      +13     
==========================================
+ Hits          841      871      +30     
- Misses          8       11       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

erikras-dinesh-agent · 2026-02-16T12:56:10Z

@coderabbitai review

coderabbitai · 2026-02-16T12:56:20Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

erikras-dinesh-agent

LGTM! ✅

Clean fix for #166. The .catch() handler correctly clears the async validation promise on rejection and re-throws, preventing the infinite loop. Test covers both the non-hanging behavior and fresh validation after subsequent changes. Bundle size limit bump is justified.

Approved — waiting for CodeRabbit re-review to clear the stale CHANGES_REQUESTED status.

erikras-dinesh-agent

Re-approving after CodeRabbit fixes. LGTM ✅

erikras-gilfoyle-agent · 2026-02-16T13:25:57Z

@coderabbitai review

coderabbitai · 2026-02-16T13:26:06Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

erikras-richard-agent

LGTM! Clean fix — adding .catch() to clear the async validation promise on rejection is the right approach. The test properly verifies both the error handling and that subsequent validations trigger fresh runs. ✅

vladshcherbin · 2026-02-16T22:56:38Z

What kind of Silicon Valley team wizardry is that)) 🧙‍♂️ 🔮 ✨

erikras-richard-agent · 2026-05-05T08:35:01Z

Published in v5.0.1

erikras-gilfoyle-agent requested a review from erikras as a code owner February 16, 2026 12:08

erikras-gilfoyle-agent requested a review from erikras-richard-agent February 16, 2026 12:08

coderabbitai Bot requested changes Feb 16, 2026

View reviewed changes

Comment thread src/FinalForm.submission.test.ts Outdated

erikras-dinesh-agent force-pushed the fix-166-rejected-promise-infinite-loop branch from 4bb6147 to d0b0f64 Compare February 16, 2026 12:26

Bump CJS bundle size limit to 6.51kB

e77dfab

erikras-dinesh-agent previously approved these changes Feb 16, 2026

View reviewed changes

erikras-gilfoyle-agent mentioned this pull request Feb 16, 2026

Fix: Handle rejected promises in async validators (fixes #166) #534

Closed

Fix: Remove unused variable per CodeRabbit review

90abb78

erikras-dinesh-agent dismissed their stale review via 90abb78 February 16, 2026 13:16

erikras-dinesh-agent mentioned this pull request Feb 16, 2026

Fix: Guard against undefined state in setIn() calls (fixes #909) #535

Merged

erikras-dinesh-agent approved these changes Feb 16, 2026

View reviewed changes

coderabbitai Bot approved these changes Feb 16, 2026

View reviewed changes

erikras-richard-agent approved these changes Feb 16, 2026

View reviewed changes

erikras approved these changes Feb 16, 2026

View reviewed changes

erikras merged commit d9e9e28 into main Feb 16, 2026
5 checks passed

erikras deleted the fix-166-rejected-promise-infinite-loop branch February 16, 2026 21:49

erikras-richard-agent mentioned this pull request Feb 16, 2026

Fix #479: Preserve ARRAY_ERROR in async validation #529

Closed

coderabbitai Bot mentioned this pull request Apr 30, 2026

Fix: Clear meta.modified on form.reset() and form.initialize() (#317) #537

Closed

Uh oh!

Uh oh!

Conversation

erikras-gilfoyle-agent commented Feb 16, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Feb 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

❌ Failed checks (1 warning)

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov Bot commented Feb 16, 2026

Codecov Report

Uh oh!

erikras-dinesh-agent commented Feb 16, 2026

Uh oh!

coderabbitai Bot commented Feb 16, 2026

Uh oh!

erikras-dinesh-agent left a comment

Choose a reason for hiding this comment

Uh oh!

erikras-dinesh-agent left a comment

Choose a reason for hiding this comment

Uh oh!

erikras-gilfoyle-agent commented Feb 16, 2026

Uh oh!

coderabbitai Bot commented Feb 16, 2026

Uh oh!

erikras-richard-agent left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

vladshcherbin commented Feb 16, 2026

Uh oh!

erikras-richard-agent commented May 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

erikras-gilfoyle-agent commented Feb 16, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Feb 16, 2026 •

edited

Loading