Fixed isEqual register initalization#480
Merged
Merged
Conversation
erikras-richard-agent
force-pushed
the
bug/is-equal-initialization
branch
from
February 10, 2026 13:05
a6ef86a to
86e7e6c
Compare
erikras
approved these changes
Feb 10, 2026
erikras-dinesh-agent
pushed a commit
that referenced
this pull request
Feb 10, 2026
The field object literal was missing the isEqual property in its initial definition, causing TypeScript to fail when it was assigned later. Add isEqual: tripleEquals to the initial field object to match the InternalFieldState type. Fixes TypeScript compilation broken by #480.
erikras-richard-agent
pushed a commit
that referenced
this pull request
Feb 10, 2026
The field object literal was missing the isEqual property in its initial definition, causing TypeScript to fail when it was assigned later. Add isEqual: tripleEquals to the initial field object to match the InternalFieldState type. Fixes TypeScript compilation broken by #480.
erikras
pushed a commit
that referenced
this pull request
Feb 11, 2026
The field object literal was missing the isEqual property in its initial definition, causing TypeScript to fail when it was assigned later. Add isEqual: tripleEquals to the initial field object to match the InternalFieldState type. Fixes TypeScript compilation broken by #480. Co-authored-by: Erik Rasmussen <[email protected]>
erikras-dinesh-agent
pushed a commit
to erikras-gilfoyle-agent/final-form
that referenced
this pull request
Feb 11, 2026
Integrated upstream changes: - PR final-form#480: Improved isEqual register initialization - PR final-form#517: Fixed TypeScript isEqual errors Preserved async validation tracking: - instanceId for stable field instance tracking - asyncValidationCount and asyncValidationKey The merge keeps the upstream's robust isEqual initialization logic while maintaining the per-field async validation tracking needed to prevent race conditions.
erikras
pushed a commit
that referenced
this pull request
Feb 11, 2026
* Migrate from bundlesize to size-limit Replace bundlesize with size-limit to resolve iltorb compilation issues. - Remove: bundlesize (depends on unmaintained iltorb) - Add: @size-limit/preset-small-lib and size-limit - Configure: Track 4 build outputs (umd.min, umd, es, cjs) with 3kB limits This follows the same pattern as react-final-form #1056. Part of OSS-28: Migrate all libraries from bundlesize to size-limit * Address CodeRabbit feedback 1. Update Node version requirement to >=18 (size-limit requires ^18.0.0 || >=20.0.0) 2. Add size-limit check to CI workflow - New 'size' job that builds and runs size-limit - Ensures bundle size limits are enforced in CI * Update yarn.lock for size-limit dependencies * Fix TypeScript error in isEqual initialization The field object literal was missing the isEqual property in its initial definition, causing TypeScript to fail when it was assigned later. Add isEqual: tripleEquals to the initial field object to match the InternalFieldState type. Fixes TypeScript compilation broken by #480. * Adjust size-limit thresholds to match actual bundle sizes Current bundle sizes (brotli compressed): - umd.min: ~6 kB (limit: 7kB with headroom) - umd: ~6 kB (limit: 7kB with headroom) - es: ~5.5 kB (limit: 6kB with headroom) - cjs: ~5.75 kB (limit: 6kB with headroom) Limits set with ~1kB headroom to catch regressions. --------- Co-authored-by: Erik Rasmussen <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix final-form/react-final-form#1032 by updating the field
isEqualevery timeregisterFieldis called. This is in conjunction with final-form/react-final-form#1033 that so thatisEqualis passed only when defined.