Skip to content

fix: async validating#473

Merged
gertdreyer merged 1 commit into
final-form:mainfrom
xxleyi:fix-async-validating
Mar 3, 2023
Merged

fix: async validating#473
gertdreyer merged 1 commit into
final-form:mainfrom
xxleyi:fix-async-validating

Conversation

@xxleyi

@xxleyi xxleyi commented Feb 26, 2023

Copy link
Copy Markdown
Contributor

@xxleyi
xxleyi force-pushed the fix-async-validating branch from eb22c35 to 72c9d73 Compare February 26, 2023 09:25
@gertdreyer

Copy link
Copy Markdown
Contributor

Hi @xxleyi , can you please add a test that fails prior to your change and passes afterwards? Thus we can ensure we have no regression of the same issue in the future

@xxleyi

xxleyi commented Mar 3, 2023

Copy link
Copy Markdown
Contributor Author

@gertdreyer Test has already been provided by @iamdey in react-final-form, final-form/react-final-form#1018. I tried and it worked well.

@gertdreyer

Copy link
Copy Markdown
Contributor

Can you include that test in the automated testing?

@xxleyi

xxleyi commented Mar 3, 2023

Copy link
Copy Markdown
Contributor Author

@gertdreyer these are two repo, you mean I include that test in final-form?

@gertdreyer

Copy link
Copy Markdown
Contributor

It should be possible to do it in a vanilla JS test in this repo - if you want to attempt that, otherwise, I am happy to merge as is due to the existing bug examples and tests being in RFF.

@xxleyi

xxleyi commented Mar 3, 2023

Copy link
Copy Markdown
Contributor Author

@gertdreyer I don't have many experience on JS test, so maybe merge firstly? I will try add test later.

@gertdreyer
gertdreyer merged commit d20c44b into final-form:main Mar 3, 2023
@xxleyi

xxleyi commented Jul 26, 2023

Copy link
Copy Markdown
Contributor Author

@gertdreyer Sorry to bother, I added test PR #475, and we are still meeting this problem, can we publish a new version?

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Async validator on unregister set validating to true

2 participants