fix(toPath): handle idiomatic JS paths with arbitrary string properties#381
Merged
Conversation
Contributor
|
When this is merged, make sure to update final-form-array because it does not handle idiomatic JS paths |
Contributor
Author
|
@erikras do you want me to make changes? What can I do to help get this merged? |
Member
|
Published in v4.20.3. |
Contributor
Author
|
Thanks! |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #380
Since doing this right is non-trivial, I copied over the code from lodash'
stringToPathand appended lodash' license to theLICENSE.Although we could use the
lodash.topath, those modular build packages are discouraged and will be removed in v5.The better alternative, really, is just to depend on
lodashand importtoPathfrom it. People are averse to transitive deps but only the codetoPathdepends on would get bundled, and that code could be shared with any other packages/userland code that rely ontoPath, so it can result in smaller overall bundle sizes than duplicating the code or using thelodash.topathmodular build package.