Skip to content

Fix bug when mutator removes field state#246

Merged
erikras merged 1 commit into
masterfrom
fix-undefined-fieldstate-bug
Jul 15, 2019
Merged

Fix bug when mutator removes field state#246
erikras merged 1 commit into
masterfrom
fix-undefined-fieldstate-bug

Conversation

@erikras

@erikras erikras commented Jul 15, 2019

Copy link
Copy Markdown
Member

No description provided.

@codecov

codecov Bot commented Jul 15, 2019

Copy link
Copy Markdown

Codecov Report

Merging #246 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #246   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines         546    545    -1     
  Branches      111    111           
=====================================
- Hits          546    545    -1
Impacted Files Coverage Δ
src/FinalForm.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d169b2...3ae8f96. Read the comment docs.

@erikras
erikras merged commit 7abee7c into master Jul 15, 2019
@erikras
erikras deleted the fix-undefined-fieldstate-bug branch July 15, 2019 17:05
@erikras

erikras commented Jul 15, 2019

Copy link
Copy Markdown
Member Author

Published in v4.18.1.

@mohsinulhaq

Copy link
Copy Markdown

I was about to log an issue regarding this and I came across this commit at the exact line where I was getting the error at :)

@Sharakai

Copy link
Copy Markdown

FWIW: this can also occur on the line below, with delete state.fieldSubscribers[name].entries[index] - Would probably be nice to extend this check to include if (state.fieldSubscribers[name]) too.

@lock

lock Bot commented Aug 24, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked as resolved and limited conversation to collaborators Aug 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants