Skip to content

Added internal forceUpdate flag for fields for final-form-arrays' mutators#244

Merged
erikras merged 2 commits into
masterfrom
allow-field-forceUpdate
Jul 13, 2019
Merged

Added internal forceUpdate flag for fields for final-form-arrays' mutators#244
erikras merged 2 commits into
masterfrom
allow-field-forceUpdate

Conversation

@erikras

@erikras erikras commented Jul 13, 2019

Copy link
Copy Markdown
Member

Mutators can now mark a field as forceUpdate to ensure that its subscribers will be notified.

@codecov

codecov Bot commented Jul 13, 2019

Copy link
Copy Markdown

Codecov Report

Merging #244 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #244   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines         542    544    +2     
  Branches      111    112    +1     
=====================================
+ Hits          542    544    +2
Impacted Files Coverage Δ
src/FinalForm.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17de69c...fdeac83. Read the comment docs.

2 similar comments
@codecov

codecov Bot commented Jul 13, 2019

Copy link
Copy Markdown

Codecov Report

Merging #244 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #244   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines         542    544    +2     
  Branches      111    112    +1     
=====================================
+ Hits          542    544    +2
Impacted Files Coverage Δ
src/FinalForm.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17de69c...fdeac83. Read the comment docs.

@codecov

codecov Bot commented Jul 13, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #244 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #244   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines         542    544    +2     
  Branches      111    112    +1     
=====================================
+ Hits          542    544    +2
Impacted Files Coverage Δ
src/FinalForm.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17de69c...fdeac83. Read the comment docs.

@erikras
erikras merged commit eb2627c into master Jul 13, 2019
@erikras
erikras deleted the allow-field-forceUpdate branch July 13, 2019 18:36
@erikras erikras mentioned this pull request Jul 15, 2019
Merged
@erikras

erikras commented Jul 15, 2019

Copy link
Copy Markdown
Member Author

Reverted in v4.18.0.

@lock

lock Bot commented Aug 14, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked as resolved and limited conversation to collaborators Aug 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@erikras