add dirtyFields type#158
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #158 +/- ##
=======================================
Coverage ? 100%
=======================================
Files ? 12
Lines ? 505
Branches ? 103
=======================================
Hits ? 505
Misses ? 0
Partials ? 0Continue to review full report at Codecov.
|
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Member
|
Published in |
erikras-dinesh-agent
pushed a commit
that referenced
this pull request
Feb 16, 2026
- Add null check in getValidators to prevent crash when field is undefined - This fixes react-final-form-arrays #158 where removing array items causes validation to access validators on deleted field objects - Add test that reproduces the crash and verifies the fix
erikras-dinesh-agent
pushed a commit
that referenced
this pull request
Feb 16, 2026
- Add null check in getValidators to prevent crash when field is undefined - This fixes react-final-form-arrays #158 where removing array items causes validation to access validators on deleted field objects - Add test that reproduces the crash and verifies the fix
erikras-dinesh-agent
pushed a commit
that referenced
this pull request
Feb 16, 2026
- Add null check in getValidators to prevent crash when field is undefined - This fixes react-final-form-arrays #158 where removing array items causes validation to access validators on deleted field objects - Add test that reproduces the crash and verifies the fix
erikras-dinesh-agent
pushed a commit
that referenced
this pull request
Feb 16, 2026
- Add null check in getValidators to prevent crash when field is undefined - This fixes react-final-form-arrays #158 where removing array items causes validation to access validators on deleted field objects - Add test that reproduces the crash and verifies the fix
erikras-dinesh-agent
pushed a commit
that referenced
this pull request
Feb 16, 2026
- Add null check in getValidators to prevent crash when field is undefined - This fixes react-final-form-arrays #158 where removing array items causes validation to access validators on deleted field objects - Add test that reproduces the crash and verifies the fix
erikras
pushed a commit
that referenced
this pull request
Feb 16, 2026
* Fix #158: Guard against undefined field in getValidators - Add null check in getValidators to prevent crash when field is undefined - This fixes react-final-form-arrays #158 where removing array items causes validation to access validators on deleted field objects - Add test that reproduces the crash and verifies the fix * Increase CJS bundle size limit for safety guard The guard check in getValidators() adds 14-30 bytes to prevent crashes when accessing validators on undefined fields. Small size increase is acceptable for critical bug fix. --------- Co-authored-by: erikras-dinesh-agent <[email protected]>
Contributor
|
Fix published in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Related to : #157
Just adding missing types for dirtyFields in FormState and FormSubscription