Add Support for Scala 2.13 and drop support for Scala 2.11 by rpless · Pull Request #1204 · finagle/finch

rpless · 2020-02-10T15:16:13Z

Resolves #1202 by adding support for 2.13. We're also forced to drop support for 2.11 here because a number of dependencies that are not cross built for both. Big thanks to @sergeykolbasov for figuring the weird SAM issue that caused the Mapper to not get resolved in a bunch of cases.

Couple things about this PR:

Introduces a bunch of warnings from Scalatest, I plan on cleaning these up in a separate PR
I'd still like to investigate cleaning up the sbt settings, I really like how Odin is does it.
Examples and docs cannot be cross built until Twitter Server is cross built for 2.13

codecov-io · 2020-02-10T15:23:14Z

Codecov Report

Merging #1204 into master will increase coverage by 1.84%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1204      +/-   ##
==========================================
+ Coverage   80.29%   82.13%   +1.84%     
==========================================
  Files          55       54       -1     
  Lines        1025      991      -34     
  Branches       40       42       +2     
==========================================
- Hits          823      814       -9     
+ Misses        202      177      -25

Impacted Files	Coverage Δ
...in/scala/io/finch/circe/AccumulatingDecoders.scala	`100% <ø> (ø)`	⬆️
circe/src/main/scala/io/finch/circe/package.scala	`100% <100%> (ø)`	⬆️
circe/src/main/scala/io/finch/circe/Encoders.scala	`100% <100%> (ø)`	⬆️
core/src/main/scala/io/finch/Endpoint.scala	`71.66% <100%> (-0.87%)`	⬇️
core/src/main/scala/io/finch/internal/Mapper.scala	`100% <100%> (ø)`	⬆️
core/src/main/scala/io/finch/Error.scala	`55.55% <0%> (-11.12%)`	⬇️
core/src/main/scala/io/finch/EndpointResult.scala	`71.42% <0%> (-9.53%)`	⬇️
core/src/main/scala/io/finch/EndpointModule.scala	`75.43% <0%> (-1.76%)`	⬇️
core/src/main/scala/io/finch/endpoint/method.scala	`100% <0%> (ø)`	⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66afd37...a3d3be4. Read the comment docs.

rpless · 2020-02-10T15:30:52Z

Hrm, not sure what's up with that coverage report. I might try to re-apply these changes directly to master instead of merging master into it.

sergeykolbasov · 2020-02-10T15:57:16Z

build.sbt

+  // Bring back examples when Twitter Server is published for Scala 2.13.
  .aggregate(
-    core, fs2, iteratee, generic, argonaut, circe, benchmarks, test, jsonTest, examples, refined
+    core, fs2, iteratee, generic, argonaut, circe, benchmarks, test, jsonTest, /*examples,*/ refined


Doesn't examples work just fine with crossScalaVersions := Seq("2.12.7") setting?

It works fine for sbt validate which doesn't cross build, but breaks on things like sbt +compile trying to fetch 2.13 dependencies. I think its because its inheriting the crossVersions of the aggregate project and not respecting the child projects override.

Yeah, I see it now:

Issuing a cross building command, but not all sub projects have the same cross build configuration. This could result in subprojects cross building against Scala versions that they are not compatible with. Try issuing cross building command with tasks instead, since sbt will be able to ensure that cross building is only done using configured project and Scala version combinations that are configured.

I wish I'd understand whatever the Try issuing cross building command with tasks instead means

rpless · 2020-02-11T01:10:44Z

Ok I've managed to fix the coverage report by reapplying my changes to master instead of having the merge commit. I also cleaned up a couple unneeded things. AND because Travis released Circe 0.13 between when I posted this PR and when I got home, I was able to use that instead of the milestone build.
I'm gonna re-evaluate scalacOptions tomorrow. A cursory look at Odin's options tells me we're missing some of the unused ones we rely on.

… scala

rpless · 2020-02-12T00:10:18Z

I think I have all of the scalacOptions figured out. We were just missing the one in the 2.13 list.

sergeykolbasov · 2020-02-12T14:20:14Z

LGTM

@vkostyukov what do you think?

sergeykolbasov · 2020-03-09T08:49:46Z

Hi @rpless

twitter-server got released for 2.13
https://search.maven.org/artifact/com.twitter/twitter-server_2.13/20.3.0/jar

I guess we could finish this PR now and then merge it 😎

rpless · 2020-03-09T13:01:08Z

@sergeykolbasov I agree. I just pushed something to crossbuild examples and docs to 2.13. If it builds and you think its good I'll merge.

sergeykolbasov · 2020-03-09T13:10:39Z

build.sbt

 import ReleaseTransformations._
 import microsites.ExtraMdFileConfig

+parallelExecution := false


What's up with parallel execution? Also, does this line affect anything as it's not a part of any project?

Oh, that's not needed, I'll take it out. I had in there cause one of the machines I develop on didn't quite have the horsepower to run all the tests at once and would lock up.

sergeykolbasov · 2020-03-09T13:21:45Z

build.sbt

-lazy val circeVersion = "0.11.2"
-lazy val circeIterateeVersion = "0.12.0"
-lazy val circeFs2Version = "0.11.0"
+lazy val twitterVersion = "20.1.0"


I think it should be 20.3.0

Yep good catch.

rpless · 2020-03-09T14:05:46Z

@sergeykolbasov I've fixed the version of Twitter Server and removed that parallelExecution directive. Build looks good.

sergeykolbasov · 2020-03-09T14:56:13Z

LGTM 👍

sergeykolbasov reviewed Feb 10, 2020

View reviewed changes

rpless force-pushed the rpless/scala-2.13 branch from d5db5a3 to 64b1891 Compare February 11, 2020 00:48

Add support for Scala 2.13 and drop support for Scala 2.11.

c249f90

rpless force-pushed the rpless/scala-2.13 branch from 64b1891 to c249f90 Compare February 11, 2020 00:49

sergeykolbasov changed the title ~~Add Support for Scala 2.13 and drop support for Scala 2.13~~ Add Support for Scala 2.13 and drop support for Scala 2.11 Feb 11, 2020

Maintain separate lists of compiler options for different versions of…

fe0bdd6

… scala

rpless requested review from sergeykolbasov and vkostyukov February 12, 2020 00:10

joroKr21 mentioned this pull request Mar 9, 2020

Update dependencies (except Finagle) #1169

Closed

Crossbuild examples and docs on 2.13

3ea411a

sergeykolbasov reviewed Mar 9, 2020

View reviewed changes

Remove disabling parallelExecution

91bad92

sergeykolbasov reviewed Mar 9, 2020

View reviewed changes

Bump to Finagle 20.3.0

a3d3be4

travisbrown mentioned this pull request Mar 9, 2020

Decide when to drop 2.11 support typelevel/catbird#213

Closed

rpless merged commit 195fc1a into finagle:master Mar 9, 2020

Conversation

rpless commented Feb 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-io commented Feb 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

rpless commented Feb 10, 2020

Uh oh!

sergeykolbasov Feb 10, 2020

Choose a reason for hiding this comment

Uh oh!

rpless Feb 10, 2020

Choose a reason for hiding this comment

Uh oh!

sergeykolbasov Feb 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rpless commented Feb 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rpless commented Feb 12, 2020

Uh oh!

sergeykolbasov commented Feb 12, 2020

Uh oh!

sergeykolbasov commented Mar 9, 2020

Uh oh!

rpless commented Mar 9, 2020

Uh oh!

sergeykolbasov Mar 9, 2020

Choose a reason for hiding this comment

Uh oh!

rpless Mar 9, 2020

Choose a reason for hiding this comment

Uh oh!

sergeykolbasov Mar 9, 2020

Choose a reason for hiding this comment

Uh oh!

rpless Mar 9, 2020

Choose a reason for hiding this comment

Uh oh!

rpless commented Mar 9, 2020

Uh oh!

sergeykolbasov commented Mar 9, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

rpless commented Feb 10, 2020 •

edited

Loading

codecov-io commented Feb 10, 2020 •

edited

Loading

sergeykolbasov Feb 11, 2020 •

edited

Loading

rpless commented Feb 11, 2020 •

edited

Loading