Disable shutdown function when not registered#773
Merged
denis-sokolov merged 2 commits intofilp:masterfrom Jun 16, 2025
Merged
Conversation
denis-sokolov
force-pushed
the
unregister_shutdown_function
branch
from
57f357c to
db0f04f
Compare
Collaborator
|
Thank you! 2.18.3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A proposed fix for #772. We cannot unregister a shutdown function, but we can just make it do nothing. By checking the
isRegisteredproperty we can determine whether the shutdown function is supposed to be run at this time.Still needs a few tests; presumably by calling the shutdown function and checking it does nothing when the instance is no longer registered.