Fix passing multiple arguments to github action#82
Merged
filiph merged 1 commit intofiliph:masterfrom Sep 22, 2021
wunderundfitzig:fix/github-action-multiple-arguments
Merged
Fix passing multiple arguments to github action#82filiph merged 1 commit intofiliph:masterfrom wunderundfitzig:fix/github-action-multiple-arguments
filiph merged 1 commit intofiliph:masterfrom
wunderundfitzig:fix/github-action-multiple-arguments
Conversation
Collaborator
Author
|
Shure it would also be cool to pass arguments as real "github actions arguments" but I think then a |
Owner
|
Sorry, I didn't see this earlier. Thank you! |
|
@filiph Could you create a release so we can start using this? Thank you! :) |
Owner
|
Thanks for the nudge! The new version ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I messed up my original contribution… When one would pass more than one argument e.g.
arguments: 'example.com --skip-file skipfile.txt'to the github action it would fail with:This is because github action arguments can only be strings, but when we pass them as
argsto the dockerfile the docker cmd looks like this:cmd=["https://qa.ems.press --skipfile hui.txt"]The workaround I found is overwriting the docker
entrypointvia the actions file. There I can just expand theinputs.argumentsvariable…This should close #72