Skip to content

fix(shared): preserve URLs inside JSONC block comments - #172

Merged
filipgutica merged 2 commits into
mainfrom
fix/jsonc-block-comments-20261020
Oct 23, 2026
Merged

fix(shared): preserve URLs inside JSONC block comments#172
filipgutica merged 2 commits into
mainfrom
fix/jsonc-block-comments-20261020

Conversation

@filipgutica

@filipgutica filipgutica commented Oct 20, 2026

Copy link
Copy Markdown
Owner

Summary

Valid JSONC containing a URL in a block comment can be rejected, causing t3.json defaults to be ignored. Parse line and block comments together so those files load correctly.

Changes

  • Backport upstream 3460497 unchanged, including its regression coverage.
  • Add the shared parser and four existing configuration tests to Workbench's CI ownership policy. The integrated upstream baseline remains 3ff5b3c.

Verification

  • Upstream's two URL-comment regressions fail on the fork baseline and pass with the fix.
  • Run vp test run packages/shared/src/schemaJson.test.ts packages/shared/src/t3ProjectFile.test.ts packages/shared/src/serverSettings.test.ts apps/server/src/project/T3ProjectFileLoader.test.ts. URL comments must preserve project defaults; malformed JSON must remain rejected.
  • Focused package, Jira-contract and native loader coverage: 95 tests passed. CI ownership coverage: 11 tests passed.
  • Shared, Workbench and contracts typechecks; package/host isolation; targeted lint and formatting passed.
  • A direct native T3ProjectFileLoader smoke check loaded a temporary JSONC file and retained its worktree default and script.

Limits

Interactive client verification is unavailable because this cloud task has no T3 Browser panel tools. Preview and CI results are reported separately; no visual waiver applies.

Model metadata is not exposed by this runtime. Harness: Codex Cloud.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:S labels Oct 20, 2026
@github-actions

github-actions Bot commented Oct 20, 2026

Copy link
Copy Markdown

Workbench demo

Open the private 20-minute demo. Sign in to Vercel, then choose Open demo. Reopening this link in the same browser resumes its running demo; Start new demo creates a fresh one. Jira starts disconnected.

Application, runtime startup, fixtures, and native smoke: PR 2325214803b69fc23f75f1b03b469547dcd3c56e. Dockerfile, build configuration, bundle export, publisher, and protected launcher: main 971a65703f823e560ac9015325525d8096397795.

Expired? Return to this link and launch again. Use synthetic content with the free OpenCode model.

@filipgutica filipgutica mentioned this pull request Oct 22, 2026
Closed
@filipgutica
filipgutica marked this pull request as ready for review October 23, 2026 02:10
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 23, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-23T02:12:54.484016Z 2325214 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@filipgutica
filipgutica merged commit 359fa3e into main Oct 23, 2026
27 checks passed
filipgutica added a commit that referenced this pull request Oct 23, 2026
@filipgutica
Merge branch 'main' into chore/upstream-sync-20261022
7657c0c 
Upstream already contains the JSONC fix that #172 backported, so its tests follow upstream's pruned versions and the backport's CI scope entry is dropped.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

size:S vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@filipgutica @Lucenx9 @ffgtu