Conversation
chore: bump filecoin-ffi to v1.34.5
rvagg
approved these changes
Jan 8, 2026
Member
rvagg
left a comment
There was a problem hiding this comment.
verified the head commit of the submodule is filecoin-project/filecoin-ffi@4b398ea which has that tag
I wish github made this easier (I have registered this complaint with them previously in a forum where they were asking for feedback on this UI!)
nijoe1
added a commit
to nijoe1/lotus
that referenced
this pull request
Jan 26, 2026
* fix(grammar): fix article usage in comments (filecoin-project#13465) fix grammar in comments * chore: bump filecoin-ffi to v1.34.5 (filecoin-project#13466) chore: bump filecoin-ffi to v1.34.5 * chore: fix method name (filecoin-project#13468) Signed-off-by: oncecelll <[email protected]> * feat(cli): implement FRC-0102 signing envelope for wallet sign/verify (filecoin-project#13388) Apply the FRC-0102 "Filecoin Signed Message" envelope by default when signing arbitrary messages, ensuring compatibility with Ledger, FilSnap, and iso-filecoin. Add --raw flag to preserve raw signing for backward compatibility. Fixes filecoin-project#13256 Fixes filecoin-project#13373 --------- Signed-off-by: Angelina <[email protected]> Co-authored-by: Rod Vagg <[email protected]> * feat: add ordering by nonce flag to get sequential messages (filecoin-project#13394) * fix: skip sender * feat: remove maybe-modify-actor * chore: removed unused args * chore: updated filecoin-ffi gitmodule with new apply message for simulation function https://github.com/nijoe1/filecoin-ffi/tree/feat/apply-message-for-simulation --------- Signed-off-by: oncecelll <[email protected]> Signed-off-by: Angelina <[email protected]> Co-authored-by: Aliz Fara <[email protected]> Co-authored-by: Phi-rjan <[email protected]> Co-authored-by: oncecelll <[email protected]> Co-authored-by: aceppaluni <[email protected]> Co-authored-by: Rod Vagg <[email protected]> Co-authored-by: Sambhav Jain <[email protected]>
nijoe1
added a commit
to nijoe1/lotus
that referenced
this pull request
Jan 26, 2026
* fix(grammar): fix article usage in comments (filecoin-project#13465) fix grammar in comments * chore: bump filecoin-ffi to v1.34.5 (filecoin-project#13466) chore: bump filecoin-ffi to v1.34.5 * chore: fix method name (filecoin-project#13468) Signed-off-by: oncecelll <[email protected]> * feat(cli): implement FRC-0102 signing envelope for wallet sign/verify (filecoin-project#13388) Apply the FRC-0102 "Filecoin Signed Message" envelope by default when signing arbitrary messages, ensuring compatibility with Ledger, FilSnap, and iso-filecoin. Add --raw flag to preserve raw signing for backward compatibility. Fixes filecoin-project#13256 Fixes filecoin-project#13373 --------- Signed-off-by: Angelina <[email protected]> Co-authored-by: Rod Vagg <[email protected]> * feat: add ordering by nonce flag to get sequential messages (filecoin-project#13394) * fix: skip sender * feat: remove maybe-modify-actor * chore: removed unused args * chore: updated filecoin-ffi gitmodule with new apply message for simulation function https://github.com/nijoe1/filecoin-ffi/tree/feat/apply-message-for-simulation --------- Signed-off-by: oncecelll <[email protected]> Signed-off-by: Angelina <[email protected]> Co-authored-by: Aliz Fara <[email protected]> Co-authored-by: Phi-rjan <[email protected]> Co-authored-by: oncecelll <[email protected]> Co-authored-by: aceppaluni <[email protected]> Co-authored-by: Rod Vagg <[email protected]> Co-authored-by: Sambhav Jain <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Bump filecoin-ffi to v1.34.5: https://github.com/filecoin-project/filecoin-ffi/releases/tag/v1.34.5
Checklist
Before you mark the PR ready for review, please make sure that: