Skip to content

fix(grammar): fix article usage in comments#13465

Merged
rjan90 merged 1 commit intofilecoin-project:masterfrom
alizfara112:grammar05
Jan 8, 2026
Merged

fix(grammar): fix article usage in comments#13465
rjan90 merged 1 commit intofilecoin-project:masterfrom
alizfara112:grammar05

Conversation

@alizfara112
Copy link
Copy Markdown
Contributor

Fixes incorrect article usage in code comments and CLI usage strings. Following up on #13435, this corrects remaining instances where "an" was incorrectly used before consonant sounds:

  • "an segment" → "a segment" (chain/sync.go)
  • "an worker" → "a worker" (cmd/lotus-shed/miner-multisig.go, 2 occurrences)
  • "in an jsonrpc" → "in a jsonrpc" (storage/sealer/worker_local.go)

@github-project-automation github-project-automation Bot moved this to 📌 Triage in FilOz Jan 6, 2026
Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-project-automation github-project-automation Bot moved this from 📌 Triage to ⌨️ In Progress in FilOz Jan 6, 2026
@alizfara112 alizfara112 changed the title fix grammar in comments fix(grammar): correct article usage in comments Jan 6, 2026
Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alizfara112 alizfara112 changed the title fix(grammar): correct article usage in comments fix(grammar): fix article usage in comments Jan 6, 2026
@github-actions github-actions Bot dismissed their stale review January 6, 2026 14:57

PR title now matches the required format.

@rjan90 rjan90 added the skip/changelog This change does not require CHANGELOG.md update label Jan 8, 2026
@github-project-automation github-project-automation Bot moved this from ⌨️ In Progress to ✔️ Approved by reviewer in FilOz Jan 8, 2026
@rjan90 rjan90 merged commit f04a4b3 into filecoin-project:master Jan 8, 2026
99 of 104 checks passed
@github-project-automation github-project-automation Bot moved this from ✔️ Approved by reviewer to 🎉 Done in FilOz Jan 8, 2026
nijoe1 added a commit to nijoe1/lotus that referenced this pull request Jan 26, 2026
* fix(grammar): fix article usage in comments (filecoin-project#13465)

fix grammar in comments

* chore: bump filecoin-ffi to v1.34.5 (filecoin-project#13466)

chore: bump filecoin-ffi to v1.34.5

* chore: fix method name (filecoin-project#13468)

Signed-off-by: oncecelll <[email protected]>

* feat(cli): implement FRC-0102 signing envelope for wallet sign/verify (filecoin-project#13388)

Apply the FRC-0102 "Filecoin Signed Message" envelope by default when
signing arbitrary messages, ensuring compatibility with Ledger, FilSnap,
and iso-filecoin. Add --raw flag to preserve raw signing for backward
compatibility.

Fixes filecoin-project#13256
Fixes filecoin-project#13373

---------

Signed-off-by: Angelina <[email protected]>
Co-authored-by: Rod Vagg <[email protected]>

* feat: add ordering by nonce flag to get sequential messages (filecoin-project#13394)

* fix: skip sender

* feat: remove maybe-modify-actor

* chore: removed unused args

* chore: updated filecoin-ffi gitmodule with new apply message for simulation function https://github.com/nijoe1/filecoin-ffi/tree/feat/apply-message-for-simulation

---------

Signed-off-by: oncecelll <[email protected]>
Signed-off-by: Angelina <[email protected]>
Co-authored-by: Aliz Fara <[email protected]>
Co-authored-by: Phi-rjan <[email protected]>
Co-authored-by: oncecelll <[email protected]>
Co-authored-by: aceppaluni <[email protected]>
Co-authored-by: Rod Vagg <[email protected]>
Co-authored-by: Sambhav Jain <[email protected]>
nijoe1 added a commit to nijoe1/lotus that referenced this pull request Jan 26, 2026
* fix(grammar): fix article usage in comments (filecoin-project#13465)

fix grammar in comments

* chore: bump filecoin-ffi to v1.34.5 (filecoin-project#13466)

chore: bump filecoin-ffi to v1.34.5

* chore: fix method name (filecoin-project#13468)

Signed-off-by: oncecelll <[email protected]>

* feat(cli): implement FRC-0102 signing envelope for wallet sign/verify (filecoin-project#13388)

Apply the FRC-0102 "Filecoin Signed Message" envelope by default when
signing arbitrary messages, ensuring compatibility with Ledger, FilSnap,
and iso-filecoin. Add --raw flag to preserve raw signing for backward
compatibility.

Fixes filecoin-project#13256
Fixes filecoin-project#13373

---------

Signed-off-by: Angelina <[email protected]>
Co-authored-by: Rod Vagg <[email protected]>

* feat: add ordering by nonce flag to get sequential messages (filecoin-project#13394)

* fix: skip sender

* feat: remove maybe-modify-actor

* chore: removed unused args

* chore: updated filecoin-ffi gitmodule with new apply message for simulation function https://github.com/nijoe1/filecoin-ffi/tree/feat/apply-message-for-simulation

---------

Signed-off-by: oncecelll <[email protected]>
Signed-off-by: Angelina <[email protected]>
Co-authored-by: Aliz Fara <[email protected]>
Co-authored-by: Phi-rjan <[email protected]>
Co-authored-by: oncecelll <[email protected]>
Co-authored-by: aceppaluni <[email protected]>
Co-authored-by: Rod Vagg <[email protected]>
Co-authored-by: Sambhav Jain <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip/changelog This change does not require CHANGELOG.md update

Projects

Status: 🎉 Done

Development

Successfully merging this pull request may close these issues.

2 participants