feat: add ordering by nonce flag to get sequential messages by DarkLord017 · Pull Request #13394 · filecoin-project/lotus

DarkLord017 · 2025-10-18T08:19:33Z

Related Issues

Fixes #13246

Proposed Changes

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

Commits have a clear commit message.
PR title conforms with contribution conventions
Update CHANGELOG.md or signal that this change does not need it per contribution conventions
New features have usage guidelines and / or documentation updates in
- Lotus Documentation
- Discussion Tutorials
Tests exist for new functionality or change in behavior
CI is green

DarkLord017 · 2025-10-18T08:37:24Z

@wjmelements is there any way to test this , like instead of running it e2e

Copilot

Pull Request Overview

This PR adds a new --order-by-nonce flag to the state list-msgs CLI command, enabling users to retrieve messages ordered sequentially by nonce when filtering by a 'from' address. This addresses issue #13246 by providing a way to view messages in the order they were intended to be executed.

Key changes:

Added --order-by-nonce boolean flag with appropriate usage documentation
Implemented message buffering and sorting logic that orders messages by nonce when the flag is enabled
The ordering only applies when a 'from' address filter is specified

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Co-authored-by: Copilot <[email protected]>

rvagg

this defaults to no ordering, but we then get the deduped per-tipset message ordering which I think is the correct default

rvagg · 2026-01-08T08:58:36Z

@DarkLord017 would you updating from master (merge from master or rebase on master) and then editing the CHANGELOG.md to note the addition of this flag. Look at other changelog entries for the pattern and make sure to reference this PR.

rvagg · 2026-01-08T09:06:52Z

oh, and make gen needs to be run too, when we edit the CLI tools we need to edit the docs that describe how to use them and they come out of the code

DarkLord017 · 2026-01-09T12:02:49Z

ya sure ! doing that

DarkLord017 · 2026-01-09T13:08:00Z

done @rvagg

rvagg

Sorry @DarkLord017, I was just reviewing the original request and it did mention the desire to --cids with this. Which is a bit more tricky because there's currently a continue for --cids so what you'd need to do is take obn into account when doing that and not continue if obn so you can fetch the message and collect the nonce, and then do CID printing at the end after sorting if obn, like you do (but just cid)

rvagg · 2026-01-19T03:29:28Z

also if you wouldn't mind resolving the conflict in CHANGELOG.md that I just made for you (sorry)

* fix(grammar): fix article usage in comments (filecoin-project#13465) fix grammar in comments * chore: bump filecoin-ffi to v1.34.5 (filecoin-project#13466) chore: bump filecoin-ffi to v1.34.5 * chore: fix method name (filecoin-project#13468) Signed-off-by: oncecelll <[email protected]> * feat(cli): implement FRC-0102 signing envelope for wallet sign/verify (filecoin-project#13388) Apply the FRC-0102 "Filecoin Signed Message" envelope by default when signing arbitrary messages, ensuring compatibility with Ledger, FilSnap, and iso-filecoin. Add --raw flag to preserve raw signing for backward compatibility. Fixes filecoin-project#13256 Fixes filecoin-project#13373 --------- Signed-off-by: Angelina <[email protected]> Co-authored-by: Rod Vagg <[email protected]> * feat: add ordering by nonce flag to get sequential messages (filecoin-project#13394) * fix: skip sender * feat: remove maybe-modify-actor * chore: removed unused args * chore: updated filecoin-ffi gitmodule with new apply message for simulation function https://github.com/nijoe1/filecoin-ffi/tree/feat/apply-message-for-simulation --------- Signed-off-by: oncecelll <[email protected]> Signed-off-by: Angelina <[email protected]> Co-authored-by: Aliz Fara <[email protected]> Co-authored-by: Phi-rjan <[email protected]> Co-authored-by: oncecelll <[email protected]> Co-authored-by: aceppaluni <[email protected]> Co-authored-by: Rod Vagg <[email protected]> Co-authored-by: Sambhav Jain <[email protected]>

github-project-automation Bot added this to FilOz Oct 18, 2025

github-project-automation Bot moved this to 📌 Triage in FilOz Oct 18, 2025

rvagg reviewed Oct 20, 2025

View reviewed changes

Comment thread cli/state.go Outdated

feat(state): add feature to get message sorted by nonce

52ac86d

DarkLord017 force-pushed the feat/order-by-nonce branch from 5d90341 to 52ac86d Compare October 20, 2025 10:33

BigLep moved this from 📌 Triage to 🔎 Awaiting Review in FilOz Oct 21, 2025

BigLep marked this pull request as ready for review October 21, 2025 05:00

Copilot AI review requested due to automatic review settings October 21, 2025 05:00

Copilot AI reviewed Oct 21, 2025

View reviewed changes

Comment thread cli/state.go Outdated

Comment thread cli/state.go Outdated

Comment thread cli/state.go Outdated

fix: ordering after loop completion

b4e2632

DarkLord017 requested a review from Copilot October 21, 2025 08:49

Copilot AI reviewed Oct 21, 2025

View reviewed changes

Comment thread cli/state.go Outdated

Comment thread cli/state.go

Comment thread cli/state.go

Update cli/state.go

e0266fb

Co-authored-by: Copilot <[email protected]>

DarkLord017 requested a review from rvagg October 24, 2025 18:41

rvagg reviewed Jan 8, 2026

View reviewed changes

Comment thread cli/state.go Outdated

Update cli/state.go

ed5a700

rvagg approved these changes Jan 8, 2026

View reviewed changes

github-project-automation Bot moved this from 🔎 Awaiting Review to ✔️ Approved by reviewer in FilOz Jan 8, 2026

DarkLord017 added 2 commits January 9, 2026 17:41

Merge branch 'filecoin-project:master' into feat/order-by-nonce

afa29bf

added changelog

f9f4713

DarkLord017 requested a review from rvagg January 13, 2026 08:03

Merge branch 'filecoin-project:master' into feat/order-by-nonce

e1b32f9

rvagg approved these changes Jan 19, 2026

View reviewed changes

rvagg requested changes Jan 19, 2026

View reviewed changes

github-project-automation Bot moved this from ✔️ Approved by reviewer to ⌨️ In Progress in FilOz Jan 19, 2026

DarkLord017 added 2 commits January 19, 2026 13:16

Merge branch 'master' into feat/order-by-nonce

f8b2bd1

fix: cid to work with obn flag

75f6455

DarkLord017 requested a review from rvagg January 19, 2026 07:59

rvagg reviewed Jan 19, 2026

View reviewed changes

Comment thread cli/state.go Outdated

Update cli/state.go

08ebc68

rvagg approved these changes Jan 19, 2026

View reviewed changes

github-project-automation Bot moved this from ⌨️ In Progress to ✔️ Approved by reviewer in FilOz Jan 19, 2026

rvagg merged commit 6a08ac4 into filecoin-project:master Jan 19, 2026
94 of 95 checks passed

github-project-automation Bot moved this from ✔️ Approved by reviewer to 🎉 Done in FilOz Jan 19, 2026

Conversation

DarkLord017 commented Oct 18, 2025

Related Issues

Proposed Changes

Additional Info

Checklist

Uh oh!

DarkLord017 commented Oct 18, 2025

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rvagg left a comment

Choose a reason for hiding this comment

Uh oh!

rvagg commented Jan 8, 2026

Uh oh!

rvagg commented Jan 8, 2026

Uh oh!

DarkLord017 commented Jan 9, 2026

Uh oh!

DarkLord017 commented Jan 9, 2026

Uh oh!

rvagg left a comment

Choose a reason for hiding this comment

Uh oh!

rvagg commented Jan 19, 2026

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants