Merged
Conversation
Collaborator
Author
|
I am done with changes. |
rvagg
reviewed
Feb 24, 2026
| sc.CommitBatchWait = time.Second | ||
| sc.StartEpochSealingBuffer = 30 | ||
|
|
||
| sc.PreCommitBatchWait = time.Second |
Collaborator
Author
There was a problem hiding this comment.
This was to speed up the LID cleanup test. Might be helpful for others as well.
rvagg
reviewed
Feb 24, 2026
Member
There was a problem hiding this comment.
👍 good sign we got frisbii updated
rvagg
reviewed
Feb 24, 2026
Member
There was a problem hiding this comment.
what's the deal with the change in this onboarding pattern through the tests, they are now two-step to get there. Is it so we test the steps separately?
Collaborator
Author
There was a problem hiding this comment.
No, I have switched to offline deals wherever I can to speed up the tests. 1 test still tests normal HTTP flow. Offline are much faster than HTTP. Typical 5-8 minute tests are now less than 5.
rvagg
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates some long overdue deps. Fixes flaky test, re-enabled identity_cid test for graphsync. It also speeds up almost all the itests. In ideal scenario, this pipeline should not take more than 5 minutes now. GA is slow due resource contention (schedule wait) on our GA server. It also adds a new test for
make reactto allow easy test for Dependabot PRs for npm updates.