Sync dependencies between linkchecker and dist tarball#2451
Conversation
jyn514
left a comment
jyn514
left a comment
There was a problem hiding this comment.
the idea makes sense to me and i think this is "just" a bug. i'm confused that we never hit it in CI though ... could you spend a bit of time investigating whether we ever run the linkchecker?
| let doc_out = builder.doc_out(host); | ||
|
|
||
| builder.ensure(Rustc::for_stage(builder, builder.top_stage, host)); | ||
| //let compiler_doc_out = builder.compiler_doc_out(host); // For the future |
There was a problem hiding this comment.
what's this "for the future" thing? is this about another PR in flight?
There was a problem hiding this comment.
This and moving doc_out into a different variable are to prepare for when we add links to the compiler docs. At the moment, they're built separately to the main docs and only get merged during the dist tarball build, so we'll need to mirror that logic across to the linkchecker to keep it happy.
But happy to remove this for now and put it back in when it's needed, if you'd prefer
There was a problem hiding this comment.
yeah, let's keep the code the same and add a comment? that way this doesn't show as a change in the git history if i need to bisect it later.
| let _guard = builder.msg_test("Linkcheck", bootstrap_host, 1); | ||
| let _time = helpers::timeit(builder); | ||
| linkchecker.delay_failure().arg(builder.out.join(host).join("doc")).run(builder); | ||
| linkchecker.delay_failure().arg(doc_out).run(builder); |
There was a problem hiding this comment.
why this change? i don't see doc_out used earlier.
jyn514
added
the
waiting-on-author
The CI does run the linkchecker (it's under |
fs-rachel
added
waiting-on-review
and removed
waiting-on-author
|
Also the CI failure here is bizarre: the doctests failed, only on
Not sure what to make of that, I'll rerun after updating the patchset (if needed) and see if it reoccurs |
this is probably something to do with remote-test-server :/ it's less flaky than it used to be but still unreliable. this LGTM other than the one comment i left above. |
jyn514
added
waiting-on-author
d1eef30 to
09415f3
Compare
|
@jyn514 How about this version? |
fs-rachel
added
waiting-on-review
and removed
waiting-on-author
This test is not (yet) running via remote-testserver. It does run under emulation, though, so qemu might be a culprit. |
|
Build succeeded:
|
github-actions
Bot
added
backport:maybe
3 participants
No description provided.