Skip to content

Remove gcc submodule and mark GCC codegen backend as unsupported#2448

Merged
bors-ferrocene[bot] merged 7 commits into
mainfrom
rachel/remove-gcc
Jul 10, 2026
Merged

Remove gcc submodule and mark GCC codegen backend as unsupported#2448
bors-ferrocene[bot] merged 7 commits into
mainfrom
rachel/remove-gcc

Conversation

@fs-rachel

Copy link
Copy Markdown
Contributor

No description provided.

@fs-rachel
fs-rachel force-pushed the rachel/remove-gcc branch 3 times, most recently from ea9fc28 to 079f45f Compare July 7, 2026 15:48
@fs-rachel
fs-rachel marked this pull request as ready for review July 7, 2026 17:28
@fs-rachel

fs-rachel commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

Current status:

  • CI passes on an earlier version of this patch, the only difference to the current patch is that it had broad #[allow(dead_code)] annotations instead of tightly-scoped #[expect(dead_code)] annotations

  • The build succeeds on my machine with the current patch

So this is ready for review

@jyn514 jyn514 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one thing i'd like you to check, one possible cleanup that's non-blocking. overall looks good :)

Comment thread src/bootstrap/src/core/builder/mod.rs Outdated
Comment thread src/bootstrap/src/core/build_steps/clippy.rs Outdated
@jyn514 jyn514 added the waiting-on-author If this PR was opened by an automation, the "author" is the assignee. label Jul 7, 2026
@fs-rachel fs-rachel added waiting-on-review and removed waiting-on-author If this PR was opened by an automation, the "author" is the assignee. labels Jul 8, 2026
@jyn514 jyn514 added waiting-on-author If this PR was opened by an automation, the "author" is the assignee. and removed waiting-on-review labels Jul 8, 2026
@fs-rachel
fs-rachel force-pushed the rachel/remove-gcc branch from 3324bea to 1f20ede Compare July 8, 2026 15:51
@fs-rachel
fs-rachel force-pushed the rachel/remove-gcc branch from 1f20ede to feec99c Compare July 8, 2026 15:53
@fs-rachel

fs-rachel commented Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

Fixed the test failures I originally had in a better way, and removed the commits which were superceded by other commits. ./x test bootstrap passes locally

@fs-rachel fs-rachel added waiting-on-review and removed waiting-on-author If this PR was opened by an automation, the "author" is the assignee. labels Jul 8, 2026

@jyn514 jyn514 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit, looks good to me with or without the suggested change. you don't need to ask for re-approval if you accept the change.

Comment thread src/bootstrap/src/core/build_steps/gcc.rs Outdated
Comment thread src/tools/tidy/src/main.rs
@fs-rachel

Copy link
Copy Markdown
Contributor Author

Accepted both suggestions

bors merge

@bors-ferrocene

Copy link
Copy Markdown
Contributor

🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set.

@bors-ferrocene

Copy link
Copy Markdown
Contributor

Build succeeded:

@bors-ferrocene
bors-ferrocene Bot merged commit 31cd51a into main Jul 10, 2026
4 checks passed
@bors-ferrocene
bors-ferrocene Bot deleted the rachel/remove-gcc branch July 10, 2026 19:42
@github-actions github-actions Bot added backport:maybe PR candidate for backport merged-in:1.98 labels Jul 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants