Expand coverage to include recent changes by Hoverbear · Pull Request #2364 · ferrocene/ferrocene

Hoverbear · 2026-05-05T18:03:53Z

#2336 fixed a number of bugs in the #[ferrocene::prevalidated] lint, this handles coverage coming from those changes.

Ferrocene-backport-of: #2364

skade

Left relevant review comments.

jyn514 · 2026-05-11T12:53:09Z

+    // We need to do a truly cursed thing here since there are no situations in public API where
+    // we can conjure ourselves a `ParseIntError` with a `NotAPowerOfTwo` in it.


if this is really the case then shouldn't we instead mark that code as unreachable?

There are ways to create IntErrorKind::PowerOfTwo, but no ways to create a ParseIntError holding a IntErrorKind::PowerOfTwo I can find.

Are you suggesting replacing

ferrocene/library/core/src/num/error.rs

Line 158 in ecfd149

IntErrorKind::NotAPowerOfTwo => "number is not a power of two",

with an unreachable? I think that's fair since we should catch test failures if that ever changes.

Do you consider that option better than my conjuration? 😅

exactly, yes, mark specifically the Display impl with unreachable.

i think it's weird for upstream to reuse the type between different APIs like this, but that's another problem ...

I'm rather unsure about making a load bearing change to the core library here.

i was imagining something like this:

ferrocene/library/core/src/num/imp/flt2dec/strategy/dragon.rs

Lines 274 to 275 in 68d8a86

#[cfg(feature = "ferrocene_test")]

unreachable!();

2365: [1.95] prevalidated fix backport r=Hoverbear a=Hoverbear Backports #2336 and #2364 as well as [`a96a73b`](a96a73b) which is new. Co-authored-by: Jynn Nelson <[email protected]> Co-authored-by: Urhengulas <[email protected]> Co-authored-by: Ana Hobden <[email protected]>

…or::Iterator>::count

…:traits::iterator::Iterator>::try_fold

…rRefSpec>::spec_try_rfold

…ts::iterator::Iterator>::try_fold

…or::Iterator>::next more

…ase_chunks

…inimum_number_nsz_f32

…[u8]>::eq_ignore_ascii_case_chunks

jyn514

thanks for working on this, and sorry i forgot about it for so long.

bors merge

jyn514 · 2026-07-16T09:36:45Z

bors r-

want to merge everything into 1.97 before we queue things up for main

bors-ferrocene · 2026-07-16T09:36:50Z

Canceled.

Expand coverage to include recent changes #2336 fixed a number of bugs in the `#[ferrocene::prevalidated]` lint, this handles coverage coming from those changes. Co-authored-by: Ana Hobden <[email protected]> Ferrocene-backport-of: #2364 Ferrocene-backported-commits: 3721072 5808810 fdb51f2 f9dff13 5052acc a9304f9 1951cfa 9d1dbcd 047f112 45d607b 0188b6c b9b6949 04c0639 d835001 a0fa6f0 9996cb7 904d211 b79e758 bd9d73d 78f6a9b bc5cb1f c92b3ec 5fa8097 733a418

2487: Backport to `release/1.97` r=jyn514 a=ferrocene-automations[bot] This PR backports the following PRs to the `release/1.97` branch: * #2429 * #2433 * #2364 (currently unmerged) * #2475 Note that the automation failed to backport some PRs automatically. Check out the [backport:manual](https://github.com/ferrocene/ferrocene/pulls?q=is%3Apr+label%3Abackport%3Amanual) for a list of them. Co-authored-by: Urhengulas <[email protected]> Co-authored-by: Felix Gilcher <[email protected]> Co-authored-by: Ana Hobden <[email protected]>

Hoverbear self-assigned this May 5, 2026

Hoverbear added the backport:1.95 label May 5, 2026

Hoverbear force-pushed the hoverbear/big-coverage-energy branch from f80c2e1 to dcf5b91 Compare May 5, 2026 18:36

Hoverbear added a commit that referenced this pull request May 5, 2026

fmt

0aa07fe

Ferrocene-backport-of: #2364

Hoverbear mentioned this pull request May 5, 2026

[1.95] prevalidated fix backport #2365

Merged

Hoverbear commented May 6, 2026

View reviewed changes

Comment thread library/coretests/tests/ferrocene/slice.rs Outdated

skade requested changes May 6, 2026

View reviewed changes

Comment thread library/core/src/fmt/mod.rs Outdated

Comment thread library/core/src/fmt/mod.rs Outdated

Comment thread library/core/src/slice/ascii.rs Outdated

jyn514 self-requested a review May 11, 2026 12:44

jyn514 reviewed May 11, 2026

View reviewed changes

jyn514 added needs-forward-port waiting-on-author If this PR was opened by an automation, the "author" is the assignee. and removed needs-forward-port labels May 11, 2026

Hoverbear removed the backport:1.95 label May 11, 2026

github-actions Bot added the merged-in:1.95 label May 11, 2026

Hoverbear added 14 commits July 15, 2026 06:41

Cover Wrapping/Saturating types

733a418

Cover core::num::<T>::saturating_div

5fa8097

Cover core::num::<T>::saturating_mul

c92b3ec

Annotate core::fmt::Formatter::<'a>::pad_formatted_parts

bc5cb1f

Cover FunnelShift unchecked_funnel_shl

78f6a9b

Cover <core::str::iter::CharIndices<'a> as core::iter::traits::iterat…

bd9d73d

…or::Iterator>::count

Fix annotation on core::fmt::Formatter::<'a>::pad_formatted_parts

b79e758

Cover <core::iter::adapters::map_while::MapWhile<I, P> as core::iter:…

904d211

…:traits::iterator::Iterator>::try_fold

Cover core::array::<impl core::cmp::PartialOrd for [T; N]>::partial_cmp

9996cb7

Cover core::fmt::Formatter::<'a>::fill

a0fa6f0

Cover core::fmt::Formatter::<'a>::align

d835001

Annotate core::num::<impl u128>::checked_ilog

04c0639

Cover <&mut I as core::iter::traits::double_ended::DoubleEndedIterato…

b9b6949

…rRefSpec>::spec_try_rfold

Cover <core::iter::adapters::scan::Scan<I, St, F> as core::iter::trai…

0188b6c

…ts::iterator::Iterator>::try_fold

Hoverbear and others added 9 commits July 15, 2026 06:41

Cover <core::str::lossy::Utf8Chunks<'a> as core::iter::traits::iterat…

45d607b

…or::Iterator>::next more

Cover and annotate core::slice::ascii::<impl [u8]>::eq_ignore_ascii_c…

047f112

…ase_chunks

fmt

9d1dbcd

Annotate core::intrinsics::maximum_number_nsz_f32 core::intrinsics::m…

1951cfa

…inimum_number_nsz_f32

Improve coverage and annotation quality on core::slice::ascii::<impl …

a9304f9

…[u8]>::eq_ignore_ascii_case_chunks

Cover <core::num::error::ParseIntError as core::fmt::Display>::fmt

5052acc

fmt

f9dff13

Correct test comment.

fdb51f2

Fix typos

5808810

Hoverbear force-pushed the hoverbear/big-coverage-energy branch 2 times, most recently from 0837260 to ab05886 Compare July 15, 2026 15:22

Hoverbear added waiting-on-review backport:1.97 and removed waiting-on-author If this PR was opened by an automation, the "author" is the assignee. labels Jul 15, 2026

Hoverbear force-pushed the hoverbear/big-coverage-energy branch from ab05886 to f303b43 Compare July 15, 2026 15:23

Set test unreachable trap for IntErrorKind::NotAPowerOfTwo

3721072

Hoverbear force-pushed the hoverbear/big-coverage-energy branch from f303b43 to 3721072 Compare July 15, 2026 17:36

jyn514 approved these changes Jul 16, 2026

View reviewed changes

jyn514 mentioned this pull request Jul 16, 2026

Backport to release/1.97 #2487

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Expand coverage to include recent changes#2364

Expand coverage to include recent changes#2364
Hoverbear wants to merge 24 commits into
mainfrom
hoverbear/big-coverage-energy

Hoverbear commented May 5, 2026

Uh oh!

Uh oh!

skade left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jyn514 May 11, 2026

Uh oh!

Hoverbear May 11, 2026

Uh oh!

jyn514 May 11, 2026 •

edited

Loading

Uh oh!

Hoverbear Jun 8, 2026

Uh oh!

jyn514 Jun 17, 2026

Uh oh!

Uh oh!

jyn514 left a comment

Uh oh!

jyn514 commented Jul 16, 2026

Uh oh!

bors-ferrocene Bot commented Jul 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		// We need to do a truly cursed thing here since there are no situations in public API where
		// we can conjure ourselves a `ParseIntError` with a `NotAPowerOfTwo` in it.

Uh oh!

Conversation

Hoverbear commented May 5, 2026

Uh oh!

Uh oh!

skade left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jyn514 May 11, 2026

Choose a reason for hiding this comment

Uh oh!

Hoverbear May 11, 2026

Choose a reason for hiding this comment

Uh oh!

jyn514 May 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Hoverbear Jun 8, 2026

Choose a reason for hiding this comment

Uh oh!

jyn514 Jun 17, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jyn514 left a comment

Choose a reason for hiding this comment

Uh oh!

jyn514 commented Jul 16, 2026

Uh oh!

bors-ferrocene Bot commented Jul 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jyn514 May 11, 2026 •

edited

Loading