Skip to content

Annotations recurse into child items#2363

Open
jyn514 wants to merge 4 commits into
mainfrom
jyn/recurse-parents
Open

Annotations recurse into child items#2363
jyn514 wants to merge 4 commits into
mainfrom
jyn/recurse-parents

Conversation

@jyn514

@jyn514 jyn514 commented May 5, 2026

Copy link
Copy Markdown
Contributor

This is useful when trying out new crates for a contract, and will also be useful for the upcoming work to add a cfg(not(subset)) cargo fix lint.

@jyn514
jyn514 requested a review from Urhengulas May 5, 2026 15:37
Urhengulas
Urhengulas requested changes May 5, 2026
View reviewed changes
Comment thread compiler/rustc_lint/src/ferrocene/mod.rs Outdated
Comment thread tests/ui/ferrocene/lint-prevalidated/crate-root-annotation.rs
@jyn514
jyn514 force-pushed the jyn/recurse-parents branch from 407f801 to 0ec3181 Compare May 11, 2026 13:23
Urhengulas
Urhengulas approved these changes Jun 17, 2026
View reviewed changes

@Urhengulas Urhengulas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. There is one place where I am unsure if there is a typo. If not please sent it to bors

Comment thread compiler/rustc_lint/src/ferrocene/mod.rs Outdated
@Urhengulas Urhengulas added waiting-on-author If this PR was opened by an automation, the "author" is the assignee. and removed waiting-on-review labels Jun 17, 2026
@tshepang

tshepang commented Jun 18, 2026

Copy link
Copy Markdown
Member

x test ferrocene/doc/symbol-report.csv fails

error[E0027]: pattern does not mention field `inherited`
   --> ferrocene/tools/symbol-report/src/main.rs:146:13
    |
146 |             ValidatedStatus::Validated { annotation: Some(_) } => {}
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ missing field `inherited`

tshepang
tshepang reviewed Jun 18, 2026
View reviewed changes
Comment thread compiler/rustc_lint/src/ferrocene/mod.rs Outdated
tshepang
tshepang reviewed Jun 18, 2026
View reviewed changes
Comment thread compiler/rustc_middle/src/middle/codegen_fn_attrs/ferrocene.rs Outdated
@jyn514
jyn514 force-pushed the jyn/recurse-parents branch 2 times, most recently from cfcff1a to 1fd666c Compare June 19, 2026 17:00
jyn514 and others added 3 commits July 14, 2026 17:27
@jyn514 @Urhengulas @tshepang
Annotations recurse into child items
8ad40a4 
This is useful when trying out new crates for a contract,
and will also be useful for the upcoming work to add a
`cfg(not(subset))` cargo fix lint.

Co-authored-by: Johann Hemmann <[email protected]>
Co-authored-by: Tshepang Mbambo <[email protected]>
@jyn514
rename validated() -> allowed_in_certified_builds()
d50d1ab
@jyn514
handle inherited validations in symbol-report
72fcba3
@jyn514
jyn514 force-pushed the jyn/recurse-parents branch from 1fd666c to 72fcba3 Compare July 14, 2026 15:42
@jyn514 jyn514 added waiting-on-review and removed waiting-on-author If this PR was opened by an automation, the "author" is the assignee. labels Jul 15, 2026
Urhengulas
Urhengulas requested changes Jul 17, 2026
View reviewed changes

@Urhengulas Urhengulas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the one comment is wrong, but otherwise looks good to me :D

Comment thread compiler/rustc_lint/src/ferrocene/mod.rs
@Urhengulas Urhengulas added waiting-on-author If this PR was opened by an automation, the "author" is the assignee. and removed waiting-on-review labels Jul 20, 2026
@fs-rachel

fs-rachel commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

@Urhengulas asked me to review that last change as Jynn is busy. Looked over the patchset as a whole to understand the logic, and the updated comment looks right to me.

@fs-rachel
fs-rachel self-requested a review July 20, 2026 12:53
@Urhengulas

Urhengulas commented Jul 20, 2026

Copy link
Copy Markdown
Member

bors merge

@fs-rachel

fs-rachel commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

bors retry

@bors-ferrocene

bors-ferrocene Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Already running a review

bors-ferrocene Bot added a commit that referenced this pull request Jul 20, 2026
@bors-ferrocene @jyn514
@Urhengulas @Hoverbear
Merge #2363 #2476
b17870e 
2363: Annotations recurse into child items r=Urhengulas a=jyn514

This is useful when trying out new crates for a contract, and will also be useful for the upcoming work to add a `cfg(not(subset))` cargo fix lint.

2476: No RHIVOS in main safety man r=Urhengulas a=Hoverbear

#2388 touched this so we touch it again. RHIVOS should be in the safety manual for RHIVOS, not main one.


Co-authored-by: jyn <[email protected]>
Co-authored-by: Johann Hemmann <[email protected]>
Co-authored-by: Ana Hobden <[email protected]>
@bors-ferrocene

bors-ferrocene Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Build failed (retrying...):

  • full

bors-ferrocene Bot added a commit that referenced this pull request Jul 21, 2026
@bors-ferrocene @jyn514 @Urhengulas
Merge #2363
463cef7 
2363: Annotations recurse into child items r=Urhengulas a=jyn514

This is useful when trying out new crates for a contract, and will also be useful for the upcoming work to add a `cfg(not(subset))` cargo fix lint.

Co-authored-by: jyn <[email protected]>
Co-authored-by: Johann Hemmann <[email protected]>
@bors-ferrocene

bors-ferrocene Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Build failed:

  • full

@fs-rachel

fs-rachel commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Merge failed with:

error[E0599]: no method named `validated` found for enum `ValidatedStatus` in the current scope
   --> src/librustdoc/html/render/mod.rs:884:41
    |
884 |     item_is_validated(cx.tcx(), def_id).validated()
    |                                         ^^^^^^^^^ method not found in `ValidatedStatus`
    |
help: there is a variant with a similar name (notice the capitalization)
    |
884 -     item_is_validated(cx.tcx(), def_id).validated()
884 +     item_is_validated(cx.tcx(), def_id).Validated()
    |

( https://app.circleci.com/pipelines/gh/ferrocene/ferrocene/19390/workflows/ad96e964-90bf-458c-b3b9-e90926a50a0b/jobs/188079 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tshepang tshepang tshepang left review comments
@Urhengulas Urhengulas Urhengulas approved these changes
@fs-rachel fs-rachel fs-rachel approved these changes

Assignees

No one assigned

Labels

waiting-on-author If this PR was opened by an automation, the "author" is the assignee.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jyn514 @tshepang @fs-rachel @Urhengulas